Thread: Re: Remove unused rel parameter in lookup_var_attr_stats
On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> wrote:
Hi hackers,
I've attached a small patch that remove unused parameter 'rel' from
the static function lookup_var_attr_stats() in extended_stats.c
While exploring src/backend/statistics, I noticed that there are several
other parameters which appear to be unused. However, since the
discussion around import/export statistics [1] attribute_stats.c is
still ongoing and many functions from other files are non-static, those
parameters may yet prove useful. Therefore, I'm only removing the
parameter from this static function.
LGTM looks like a leftover from a4d75c86.
Regards,
Fabrízio de Royes Mello
On 03.01.2025 18:42, Fabrízio de Royes Mello wrote:
On Fri, Jan 3, 2025 at 11:09 AM Ilia Evdokimov <ilya.evdokimov@tantorlabs.com> wrote:Hi hackers,
I've attached a small patch that remove unused parameter 'rel' from
the static function lookup_var_attr_stats() in extended_stats.c
While exploring src/backend/statistics, I noticed that there are several
other parameters which appear to be unused. However, since the
discussion around import/export statistics [1] attribute_stats.c is
still ongoing and many functions from other files are non-static, those
parameters may yet prove useful. Therefore, I'm only removing the
parameter from this static function.LGTM looks like a leftover from a4d75c86.Regards,--Fabrízio de Royes Mello
True. Moreover, I checked the commit and found nothing else.
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.