Thread: Re: BUG #18755: Using Natts_pg_trigger rather than Natts_pg_event_trigger for event trigger
Re: BUG #18755: Using Natts_pg_trigger rather than Natts_pg_event_trigger for event trigger
From
"张鑫"
Date:
Hi everyone!
Here is the fix for BUG #18755. I fail to upload the patch with my mailbox and I just paste the text here because it's simple enough.
From 94009c0ae26443d03bd81ec10a1b666a4c10def4 Mon Sep 17 00:00:00 2001
From: "Xin Zhang" <zhanghien@qq.com>
Date: Sun, 29 Dec 2024 17:08:53 +0800
Subject: [PATCH] Replace Natts_pg_trigger with Natts_pg_event_trigger for
event trigger
---
src/backend/commands/event_trigger.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c
index dcfc1dbaffd..1f5872554d4 100644
--- a/src/backend/commands/event_trigger.c
+++ b/src/backend/commands/event_trigger.c
@@ -276,8 +276,8 @@ insert_event_trigger_tuple(const char *trigname, const char *eventname, Oid evtO
Relation tgrel;
Oid trigoid;
HeapTuple tuple;
- Datum values[Natts_pg_trigger];
- bool nulls[Natts_pg_trigger];
+ Datum values[Natts_pg_event_trigger];
+ bool nulls[Natts_pg_event_trigger];
NameData evtnamedata,
evteventdata;
ObjectAddress myself,
--
2.39.3
Re: BUG #18755: Using Natts_pg_trigger rather than Natts_pg_event_trigger for event trigger
From
David Rowley
Date:
On Sun, 29 Dec 2024 at 22:37, 张鑫 <zhanghien@qq.com> wrote: > Here is the fix for BUG #18755. I fail to upload the patch with my mailbox and I just paste the text here because it'ssimple enough. I've not seen this bug report. Perhaps it's caught up in moderation? > --- a/src/backend/commands/event_trigger.c > +++ b/src/backend/commands/event_trigger.c > @@ -276,8 +276,8 @@ insert_event_trigger_tuple(const char *trigname, const char *eventname, Oid evtO > Relation tgrel; > Oid trigoid; > HeapTuple tuple; > - Datum values[Natts_pg_trigger]; > - bool nulls[Natts_pg_trigger]; > + Datum values[Natts_pg_event_trigger]; > + bool nulls[Natts_pg_event_trigger]; > NameData evtnamedata, > evteventdata; > ObjectAddress myself, Yes, that's better. However, no particular harm done since pg_trigger has more columns than pg_event_trigger. For that reason, it's probably fine to fix in master only. The number of columns in those tables in the back branches isn't going to change. I scanned around to see if there's been any similar copy/paste errors, but couldn't see any. I'll take care of pushing this. Thanks for the patch. David