Thread: Re: DOCS: pg_createsubscriber wrong link?
On Fri, Dec 13, 2024 at 10:58 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> While reviewing the pg_createsubscriber [1] docs I found a potentially
> wrong linkend.
>
> This sentence:
> "For smaller databases, initial data synchronization is recommended."
>
> links to [2] ("29.4.5. Initial Data Synchronization").
>
> This seems to have been deliberately changed (commit [3])
>
Yeah, the change made by commit 84db9a0eb1 is wrong and your latest
patch in this thread looks good to me. I am adding Daniel and the
original author to see if they think differently.
--
With Regards,
Amit Kapila.
On 16.12.2024 13:56, Amit Kapila wrote:
On Fri, Dec 13, 2024 at 10:58 AM Peter Smith <smithpb2250@gmail.com> wrote:While reviewing the pg_createsubscriber [1] docs I found a potentially wrong linkend. This sentence: "For smaller databases, initial data synchronization is recommended." links to [2] ("29.4.5. Initial Data Synchronization"). This seems to have been deliberately changed (commit [3])Yeah, the change made by commit 84db9a0eb1 is wrong and your latest patch in this thread looks good to me. I am adding Daniel and the original author to see if they think differently.
It looks like my mistake. I missed that "Initial Data Synchronization" section is a subsection of "Row filters". There is no hidden reason other than matching the link name with the subsection name and my inattention. v2 of proposed patch looks good to me.
-- Pavel Luzanov Postgres Professional: https://postgrespro.com
On Mon, Dec 16, 2024 at 9:12 PM Pavel Luzanov <p.luzanov@postgrespro.ru> wrote: > > On 16.12.2024 13:56, Amit Kapila wrote: > > > Yeah, the change made by commit 84db9a0eb1 is wrong and your latest > patch in this thread looks good to me. I am adding Daniel and the > original author to see if they think differently. > > It looks like my mistake. > I missed that "Initial Data Synchronization" section is a subsection > of "Row filters". There is no hidden reason other than matching > the link name with the subsection name and my inattention. > > v2 of proposed patch looks good to me. > Thanks for the confirmation. I'll push the patch. -- With Regards, Amit Kapila.