Make getObjectDescription robust against dangling amproc type links.
Yoran Heling reported a case where a data type could be dropped
while references to its OID remain behind in pg_amproc. This
causes getObjectDescription to fail, which blocks dropping the
operator family (since our DROP code likes to construct descriptions
of everything it's dropping). The proper fix for this requires
adding more pg_depend entries. But to allow DROP to go through with
already-corrupt catalogs, tweak getObjectDescription to print "???"
for the type instead of failing when it processes such an entry.
I changed the logic for pg_amop similarly, for consistency,
although it is not known that the problem can manifest in pg_amop.
Per report from Yoran Heling. Back-patch to all supported
branches (although the problem may be unreachable in v13).
Discussion: https://postgr.es/m/Z1MVCOh1hprjK5Sf@gmai021
Branch
------
REL_16_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/faad0183507b9185382b0ab6f7701144b8cc5687
Modified Files
--------------
src/backend/catalog/objectaddress.c | 24 ++++++++++++++++++++----
1 file changed, 20 insertions(+), 4 deletions(-)
