Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: Fix tiny memory leaks

Re: Fix tiny memory leaks

From
Daniel Gustafsson
Date:
> On 6 Dec 2024, at 09:38, Tofig Aliev <t.aliev@postgrespro.ru> wrote:

> There is a memory leak in functions check_application_name() and check_cluster_name().
> Functions are located in src/backend/commands/variable.c

LGTM.

--
Daniel Gustafsson

Re: Fix tiny memory leaks

From
Masahiko Sawada
Date:
On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 6 Dec 2024, at 09:38, Tofig Aliev <t.aliev@postgrespro.ru> wrote:
>
> > There is a memory leak in functions check_application_name() and check_cluster_name().
> > Functions are located in src/backend/commands/variable.c
>
> LGTM.

LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Re: Fix tiny memory leaks

From
Daniel Gustafsson
Date:
> On 9 Dec 2024, at 19:52, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 6 Dec 2024, at 09:38, Tofig Aliev <t.aliev@postgrespro.ru> wrote:
>>
>>> There is a memory leak in functions check_application_name() and check_cluster_name().
>>> Functions are located in src/backend/commands/variable.c
>>
>> LGTM.
>
> LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.

Yeah.  While fairly insignificant in nature, and there has been no complaints
until now, I'm preparing a backpatch down to REL_15_STABLE to keep the code in
sync for other backpatches to apply clean.

--
Daniel Gustafsson

Re: Fix tiny memory leaks

From
Daniel Gustafsson
Date:
> On 9 Dec 2024, at 20:03, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 9 Dec 2024, at 19:52, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>>
>> On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>>
>>>> On 6 Dec 2024, at 09:38, Tofig Aliev <t.aliev@postgrespro.ru> wrote:
>>>
>>>> There is a memory leak in functions check_application_name() and check_cluster_name().
>>>> Functions are located in src/backend/commands/variable.c
>>>
>>> LGTM.
>>
>> LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.
>
> Yeah.  While fairly insignificant in nature, and there has been no complaints
> until now, I'm preparing a backpatch down to REL_15_STABLE to keep the code in
> sync for other backpatches to apply clean.

Done, but to 16 and not 15 which was a typo in the above email.

--
Daniel Gustafsson

Re: Fix tiny memory leaks

From
Masahiko Sawada
Date:
On Mon, Dec 9, 2024 at 12:04 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 9 Dec 2024, at 20:03, Daniel Gustafsson <daniel@yesql.se> wrote:
> >
> >> On 9 Dec 2024, at 19:52, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >>
> >> On Fri, Dec 6, 2024 at 12:49 AM Daniel Gustafsson <daniel@yesql.se> wrote:
> >>>
> >>>> On 6 Dec 2024, at 09:38, Tofig Aliev <t.aliev@postgrespro.ru> wrote:
> >>>
> >>>> There is a memory leak in functions check_application_name() and check_cluster_name().
> >>>> Functions are located in src/backend/commands/variable.c
> >>>
> >>> LGTM.
> >>
> >> LGTM. It seems commit a9d58bfe8a3a missed to fix this memory leak.
> >
> > Yeah.  While fairly insignificant in nature, and there has been no complaints
> > until now, I'm preparing a backpatch down to REL_15_STABLE to keep the code in
> > sync for other backpatches to apply clean.
>
> Done, but to 16 and not 15 which was a typo in the above email.

Thank you!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com