Thread: Re: speedup ALTER TABLE ADD CHECK CONSTRAINT.

Hello!
Thanks for the patch, but I think using SPI is still not allowed here:
https://www.postgresql.org/message-id/9878.1511970441%40sss.pgh.pa.us

> if it uses SPI for sub-operations of ALTER TABLE I think that is sufficient reason to reject it out of hand.

regards, Sergei

Sergei Kornilov <sk@zsrv.org> writes:
> Hello!
> Thanks for the patch, but I think using SPI is still not allowed here:
https://www.postgresql.org/message-id/9878.1511970441%40sss.pgh.pa.us

Yeah, if you want to do this you need to code the catalog lookup in
C.  SPI just adds too many variables to what will happen, on top
of being enormously expensive compared to a handwritten lookup.

            regards, tom lane

On Mon, Dec 2, 2024 at 12:06 AM Sergei Kornilov <sk@zsrv.org> wrote:
>
> Hello!
> Thanks for the patch, but I think using SPI is still not allowed here:
https://www.postgresql.org/message-id/9878.1511970441%40sss.pgh.pa.us
>
> > if it uses SPI for sub-operations of ALTER TABLE I think that is sufficient reason to reject it out of hand.
>

Thanks for dropping this link.
i wonder what was your thoughts about this
(https://www.postgresql.org/message-id/900056D1-32DF-4927-8251-3E0C0DC407FD%40anarazel.de)
at that time?