Thread: Re: fix deprecation mention for age() and mxid_age()

Re: fix deprecation mention for age() and mxid_age()

From
Bertrand Drouvot
Date:
Hi,

On Tue, Nov 19, 2024 at 10:09:57AM +0900, Michael Paquier wrote:
> On Mon, Nov 18, 2024 at 08:11:57AM +0000, Bertrand Drouvot wrote:
> > Also it looks like that for PG 16, 7471230cc6, did put the functions description
> > in the "Control Data Functions". That looks unintentional too, so moving it to 
> > "Transaction ID and Snapshot Information Functions" section instead.
> > 
> > Please find attached the 3 patches.
> 
> Even with the monitoring query argument left aside, I agree that there
> are more upsides to not list them as deprecated for now, based on the
> reason that xid is still a data type in some catalogs, like pg_class's
> relfrozenxid and relminmxid.

Yeah, and those are most probably the main inputs for age(). In addition,
datminmxid and relminmxid are also xid and most probably the main inputs for
mxid_age().

> In short, your suggestion makes sense to me.

Thanks for the feedback!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



Re: fix deprecation mention for age() and mxid_age()

From
John Naylor
Date:
On Wed, Nov 20, 2024 at 12:23 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Nov 19, 2024 at 06:52:40AM +0000, Bertrand Drouvot wrote:
> > Thanks for the feedback!
>
> Done.  The section mistake in REL_16_STABLE was..  Interesting.

Hi, there is a CF entry for this -- is it ready to mark committed?

--
John Naylor
Amazon Web Services



Re: fix deprecation mention for age() and mxid_age()

From
Bertrand Drouvot
Date:
Hi,

On Wed, Dec 11, 2024 at 09:01:24AM +0900, Michael Paquier wrote:
> On Wed, Dec 11, 2024 at 06:54:23AM +0700, John Naylor wrote:
> > Hi, there is a CF entry for this -- is it ready to mark committed?
> 
> Oops.  I've missed that there was an entry in CF 51.  Updated that
> now.  Thanks for the poke.

D'oh I missed it too! 

> Thanks for the poke.

+1

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com