Postgres Pro
Downloads
Home   >   mailing lists

Thread: Re: Avoid possible useless call to makeNode function (src/backend/commands/view.c)

Re: Avoid possible useless call to makeNode function (src/backend/commands/view.c)

From
David Rowley
Date:
On Wed, 30 Oct 2024 at 01:07, Ranier Vilela <ranier.vf@gmail.com> wrote:
> With the function *DefineVirtualRelation* has a possible
> useless call to *makeNode* function, which invokes palloc.
>
> So, reduce the scope for the variable to inner else
> where it is really necessary.

Seem legit. I can take care of that.

David

Re: Avoid possible useless call to makeNode function (src/backend/commands/view.c)

From
Ranier Vilela
Date:

Em ter., 29 de out. de 2024 às 09:25, David Rowley <dgrowleyml@gmail.com> escreveu:
On Wed, 30 Oct 2024 at 01:07, Ranier Vilela <ranier.vf@gmail.com> wrote:
> With the function *DefineVirtualRelation* has a possible
> useless call to *makeNode* function, which invokes palloc.
>
> So, reduce the scope for the variable to inner else
> where it is really necessary.

Seem legit. I can take care of that.
Thanks David, for the commit.

best regards,
Ranier Vilela