Thread: Re: Remove obsolete comment in reorderbuffer.h

On Sat, Oct 12, 2024 at 5:42 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I realized an obsolete comment in the definition of ReorderBufferTXN.
>
> Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
> allocating ReorderBufferTXN entries instead of using a caching
> mechanism, so the txn->node is no longer used as an element of the
> list of preallocated ReorderBufferTXNs.
>

I agree, and your patch looks good to me.

--
With Regards,
Amit Kapila.

On Sun, Oct 13, 2024 at 8:57 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sat, Oct 12, 2024 at 5:42 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I realized an obsolete comment in the definition of ReorderBufferTXN.
> >
> > Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
> > allocating ReorderBufferTXN entries instead of using a caching
> > mechanism, so the txn->node is no longer used as an element of the
> > list of preallocated ReorderBufferTXNs.
> >
>
> I agree, and your patch looks good to me.

Thank you for reviewing the patch. Pushed.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com