Thread: Re: Allow CI to only run the compiler warnings task
Hi, On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote: > > Hi hackers, > > While working on a new pg_logicalinspect module ([1]), I reached a point where > all the CI tests were green except the compiler warnings one. Then, to save time > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > I think this could be useful for others too, so please find attached this tiny > patch. +1 for this. I encountered the same issue before. > Note that the patch does not add an extra "ci-task-only", but for simplicity it > it renames ci-os-only to ci-task-only. I think this change makes sense. I gave a quick try to your patch with ci-task-only: ["", "linux", "compilerwarnings"] and it worked as expected. -- Regards, Nazir Bilal Yavuz Microsoft
Hi, On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote: > Hi, > > On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot > <bertranddrouvot.pg@gmail.com> wrote: > > > > Hi hackers, > > > > While working on a new pg_logicalinspect module ([1]), I reached a point where > > all the CI tests were green except the compiler warnings one. Then, to save time > > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > > > I think this could be useful for others too, so please find attached this tiny > > patch. > > +1 for this. I encountered the same issue before. Thanks for the feedback! > > > Note that the patch does not add an extra "ci-task-only", but for simplicity it > > it renames ci-os-only to ci-task-only. > > I think this change makes sense. I gave a quick try to your patch with > ci-task-only: ["", "linux", "compilerwarnings"] and it worked as > expected. And for the testing. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Hi, On Thu, Sep 12, 2024 at 05:21:43AM +0000, Bertrand Drouvot wrote: > Hi, > > On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote: > > Hi, > > > > On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot > > <bertranddrouvot.pg@gmail.com> wrote: > > > > > > Hi hackers, > > > > > > While working on a new pg_logicalinspect module ([1]), I reached a point where > > > all the CI tests were green except the compiler warnings one. Then, to save time > > > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > > > > > I think this could be useful for others too, so please find attached this tiny > > > patch. > > > > +1 for this. I encountered the same issue before. > > Thanks for the feedback! > > > > > > Note that the patch does not add an extra "ci-task-only", but for simplicity it > > > it renames ci-os-only to ci-task-only. > > > > I think this change makes sense. I gave a quick try to your patch with > > ci-task-only: ["", "linux", "compilerwarnings"] and it worked as > > expected. > > And for the testing. Mandatory rebase attached. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com