Thread: Re: Allow CI to only run the compiler warnings task
Hi, On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot <bertranddrouvot.pg@gmail.com> wrote: > > Hi hackers, > > While working on a new pg_logicalinspect module ([1]), I reached a point where > all the CI tests were green except the compiler warnings one. Then, to save time > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > I think this could be useful for others too, so please find attached this tiny > patch. +1 for this. I encountered the same issue before. > Note that the patch does not add an extra "ci-task-only", but for simplicity it > it renames ci-os-only to ci-task-only. I think this change makes sense. I gave a quick try to your patch with ci-task-only: ["", "linux", "compilerwarnings"] and it worked as expected. -- Regards, Nazir Bilal Yavuz Microsoft
Hi, On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote: > Hi, > > On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot > <bertranddrouvot.pg@gmail.com> wrote: > > > > Hi hackers, > > > > While working on a new pg_logicalinspect module ([1]), I reached a point where > > all the CI tests were green except the compiler warnings one. Then, to save time > > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > > > I think this could be useful for others too, so please find attached this tiny > > patch. > > +1 for this. I encountered the same issue before. Thanks for the feedback! > > > Note that the patch does not add an extra "ci-task-only", but for simplicity it > > it renames ci-os-only to ci-task-only. > > I think this change makes sense. I gave a quick try to your patch with > ci-task-only: ["", "linux", "compilerwarnings"] and it worked as > expected. And for the testing. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Hi, On Thu, Sep 12, 2024 at 05:21:43AM +0000, Bertrand Drouvot wrote: > Hi, > > On Wed, Sep 11, 2024 at 04:39:57PM +0300, Nazir Bilal Yavuz wrote: > > Hi, > > > > On Wed, 11 Sept 2024 at 15:36, Bertrand Drouvot > > <bertranddrouvot.pg@gmail.com> wrote: > > > > > > Hi hackers, > > > > > > While working on a new pg_logicalinspect module ([1]), I reached a point where > > > all the CI tests were green except the compiler warnings one. Then, to save time > > > addressing the issue, I modified the .cirrus.tasks.yml file to $SUBJECT. > > > > > > I think this could be useful for others too, so please find attached this tiny > > > patch. > > > > +1 for this. I encountered the same issue before. > > Thanks for the feedback! > > > > > > Note that the patch does not add an extra "ci-task-only", but for simplicity it > > > it renames ci-os-only to ci-task-only. > > > > I think this change makes sense. I gave a quick try to your patch with > > ci-task-only: ["", "linux", "compilerwarnings"] and it worked as > > expected. > > And for the testing. Mandatory rebase attached. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Attachment
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: tested, failed
Documentation: tested, failed
Hi Hackers,
it might be better to list tasks in alphabetical order, and if I understand correctly
initially they were alphabetically sorted.
> ci-task-only: {(compilerwarnings|freebsd|linux|macos|mingw|netbsd|openbsd|windows)}
also it may increase readability if you sort tasks alphabetically within the .cirrust.tasks.yml
Kindest regards.
Rustam
The new status of this patch is: Waiting on Author
On Wed, May 21, 2025 at 10:32 AM Rustam ALLAKOV <rustamallakov@gmail.com> wrote:
The following review has been posted through the commitfest application:
make installcheck-world: not tested
Implements feature: not tested
Spec compliant: tested, failed
Documentation: tested, failed
Hi Hackers,
it might be better to list tasks in alphabetical order, and if I understand correctly
initially they were alphabetically sorted.
> ci-task-only: {(compilerwarnings|freebsd|linux|macos|mingw|netbsd|openbsd|windows)}
Appending the option and matching the yml file is proper for this patch given its goal.
I do feel like there is something a bit off. Specifically:
I'd keep ci-os-only as a deprecated alias for a while - let it accept the new compilerwarnings task name. I'd rather not break people's muscle memory and the fact they are unlikely to realize this change until they run one through and see everything running despite their directive. The "mess" is quite minimal for the benefit.
(this is the only one I'd say is a - soft - patch blocker for me)
I'd like to communicate the always-runs versus the manual runs here in some way.
Keeping the flavors together would seem to have merit.
I feel like the yml file itself should put these in a comment block.
also it may increase readability if you sort tasks alphabetically within the .cirrust.tasks.yml
That should be done as a dedicated refactoring patch. I wouldn't consider it high priority though. I'd love to find something that makes my outliner display the task names as maximum collapse though (VS Code).
I'm apt to propose a refactoring patch here at some point to address these things - but this patch to extend the yml file in an obvious way need not take on such responsibilities.
David J.