Thread: Re: Remaining reference to _PG_fini() in ldap_password_func

On 20/08/2024 07:46, Michael Paquier wrote:
> Hi all,
> 
> While hacking on a different thing, I've noticed that
> ldap_password_func had the idea to define _PG_fini().  This is
> pointless, as library unloading is not supported in the backend, and
> something that has been cleaned up from the tree in ab02d702ef08.
> That's not something to encourage, perhaps, as well..
> 
> How about removing it like in the attached to be consistent?

+1. There's also a prototype for _PG_fini() in fmgr.h, let's remove that 
too.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 20/08/2024 07:46, Michael Paquier wrote:
>> How about removing it like in the attached to be consistent?

> +1. There's also a prototype for _PG_fini() in fmgr.h, let's remove that 
> too.

+1.  I think the fmgr.h prototype may have been left there
deliberately to avoid breaking extension code, but it's past
time to clean it up.

            regards, tom lane