Thread: create role manual

create role manual

From
Tatsuo Ishii
Date:
While my colleague is working on translating
doc/src/sgml/ref/create_role.sgml into Japanese, he has found
following sentence is hard to parse:

   The rules for which initial
   role membership options are enabled described below in the
   <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
   <literal>ADMIN</literal> clauses.

Maybe we need "are" in front of "described"?

Attached is the patch for that.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
diff --git a/doc/src/sgml/ref/create_role.sgml b/doc/src/sgml/ref/create_role.sgml
index 27e48da12a..f72ba9affc 100644
--- a/doc/src/sgml/ref/create_role.sgml
+++ b/doc/src/sgml/ref/create_role.sgml
@@ -71,7 +71,7 @@ in sync when changing the above synopsis!
    During role creation it is possible to immediately assign the newly created
    role to be a member of an existing role, and also assign existing roles
    to be members of the newly created role.  The rules for which initial
-   role membership options are enabled described below in the
+   role membership options are enabled are described below in the
    <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
    <literal>ADMIN</literal> clauses.  The <xref linkend="sql-grant"/>
    command has fine-grained option control during membership creation,

Re: create role manual

From
"David G. Johnston"
Date:
On Sat, Jun 15, 2024 at 7:25 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
   The rules for which initial
   role membership options are enabled described below in the
   <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
   <literal>ADMIN</literal> clauses.

Maybe we need "are" in front of "described"?


Agreed.

David J.

Re: create role manual

From
Tatsuo Ishii
Date:
> On Sat, Jun 15, 2024 at 7:25 PM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
> 
>>    The rules for which initial
>>    role membership options are enabled described below in the
>>    <literal>IN ROLE</literal>, <literal>ROLE</literal>, and
>>    <literal>ADMIN</literal> clauses.
>>
>> Maybe we need "are" in front of "described"?
>>
>>
> Agreed.

Thank you for the confirmation. I have pushed the change to master and
v16 stable branches.

Note that the original report was created by Satoru Koizumi, who is
one of the major contributors to PostgreSQL manual translation (to
Japanese) project. So I picked up his name as the author of the
commit.

https://github.com/pgsql-jp/jpug-doc

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp