Thread: [MASSMAIL] pgsql: pg_regress: Save errno in emit_tap_output_v() and switch to %m
[MASSMAIL] pgsql: pg_regress: Save errno in emit_tap_output_v() and switch to %m
From
Michael Paquier
Date:
pg_regress: Save errno in emit_tap_output_v() and switch to %m emit_tap_output_v() includes some fprintf() calls for some output related to the TAP protocol, that may clobber errno and break %m. This commit makes the logging of pg_regress smarter by saving errno before restoring it in vfprintf() where the input strings are used, removing the need for strerror(). All logs are switched to %m rather than strerror(), shaving some code. This was not a problem until now as pg_regress.c did not use %m, but the change is simple enough that we have no reason to not support this placeholder, and that will avoid future mistakes if new logs that include %m are added. Author: Dagfinn Ilmari Mannsåker Reviewed-by: Peter Eisentraunt, Michael Paquier Discussion: https://postgr.es/m/87sf13jhuw.fsf@wibble.ilmari.org Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/85230a247c74b92d9676abdf6693ac9d56c373cf Modified Files -------------- src/test/regress/pg_regress.c | 84 ++++++++++++++++++------------------------- 1 file changed, 34 insertions(+), 50 deletions(-)