Thread: pgsql: Update obsolete index scan TID comments.

pgsql: Update obsolete index scan TID comments.

From
Peter Geoghegan
Date:
Update obsolete index scan TID comments.

Oversight in commit c2fe139c20.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3045324214467dd3f0bef31f6f33562b9eb93aa3

Modified Files
--------------
src/backend/access/hash/hashsearch.c  |  6 +++---
src/backend/access/nbtree/nbtsearch.c | 10 +++++-----
2 files changed, 8 insertions(+), 8 deletions(-)


Re: pgsql: Update obsolete index scan TID comments.

From
Alexander Lakhin
Date:
Hello Peter,

12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.

I found one more obsolete comment mentioning xs_ctup:
             /*
              * For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
              * a virtual tuple that does not have the ctid column, so we have
              * to get the TID from xs_ctup.t_self.
              */
             IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;

             *current_tid = scan->xs_heaptid;

Maybe you would like to fix it too...

Best regards,
Alexander