Postgres Pro
Downloads
Home   >   mailing lists

Thread: Fix expecteddir argument in pg_regress

Fix expecteddir argument in pg_regress

From
Anthonin Bonnefoy
Date:
Hi all!

pg_regress accepts the expecteddir argument. However, it is never used
and outputdir is used instead to get the expected files paths.

This patch fixes this and uses the expecteddir argument as expected.

Regards,
Anthonin
Attachment

Re: Fix expecteddir argument in pg_regress

From
Daniel Gustafsson
Date:
> On 11 Mar 2024, at 09:23, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:

> pg_regress accepts the expecteddir argument. However, it is never used
> and outputdir is used instead to get the expected files paths.

Nice catch, c855872074b5bf44ecea033674d22fac831cfc31 added --expecteddir
support to pg_regress but only implemented it for the ECPG tests.  Will have
another look at this before applying with a backpatch to v16 where
--expecteddir was added.

--
Daniel Gustafsson

Re: Fix expecteddir argument in pg_regress

From
Daniel Gustafsson
Date:
> On 14 Mar 2024, at 11:45, Daniel Gustafsson <daniel@yesql.se> wrote:
>
>> On 11 Mar 2024, at 09:23, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com> wrote:
>
>> pg_regress accepts the expecteddir argument. However, it is never used
>> and outputdir is used instead to get the expected files paths.
>
> Nice catch, c855872074b5bf44ecea033674d22fac831cfc31 added --expecteddir
> support to pg_regress but only implemented it for the ECPG tests.  Will have
> another look at this before applying with a backpatch to v16 where
> --expecteddir was added.

Pushed and backpatched, thanks for the submission!

--
Daniel Gustafsson