Thread: pgsql: Remove some obsolete smgrcloseall() calls.
Remove some obsolete smgrcloseall() calls. Before the advent of PROCSIGNAL_BARRIER_SMGRRELEASE, we didn't have a comprehensive way to deal with Windows file handles that get in the way of unlinking directories. We had smgrcloseall() calls in a few places to try to mitigate. It's still a good idea for bgwriter and checkpointer to do that once per checkpoint so they don't accumulate unbounded SMgrRelation objects, but there is no longer any reason to close them at other random places such as the error path, and the explanation as given in the comments is now obsolete. Author: Thomas Munro Reviewed-by: Heikki Linnakangas, Robert Haas Discussion: https://www.postgresql.org/message-id/CA%2BhUKGJ8NTvqLHz6dqbQnt2c8XCki4r2QvXjBQcXpVwxTY_pvA@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/6a8ffe812d194ba6f4f26791b6388a4837d17d6c Modified Files -------------- src/backend/postmaster/bgwriter.c | 7 ------- src/backend/postmaster/checkpointer.c | 7 ------- src/backend/postmaster/walwriter.c | 7 ------- 3 files changed, 21 deletions(-)