Thread: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
Move src/bin/pg_verifybackup/parse_manifest.c into src/common. This makes it possible for the code to be easily reused by other client-side tools, and/or by the server. Patch by me. Review of this patch in particular by at least Peter Eisentraut; reviewers for the patch series in general include Dilip Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak. Discussion: http://postgr.es/m/CA+TgmoZ6UGZVnSy5iak6s6+AXu_DewXovDjhLs3-su6nmU_x_g@mail.gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/aafc07c7a191bc807c77fe2a044006a5db07faba Modified Files -------------- src/bin/pg_verifybackup/Makefile | 1 - src/bin/pg_verifybackup/meson.build | 1 - src/bin/pg_verifybackup/nls.mk | 4 ++-- src/bin/pg_verifybackup/pg_verifybackup.c | 2 +- src/common/Makefile | 1 + src/common/meson.build | 1 + src/{bin/pg_verifybackup => common}/parse_manifest.c | 4 ++-- src/{bin/pg_verifybackup => include/common}/parse_manifest.h | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-)
Re: pgsql: Move src/bin/pg_verifybackup/parse_manifest.c into src/common.
From
Michael Paquier
Date:
On Tue, Dec 19, 2023 at 08:29:18PM +0000, Robert Haas wrote: > Move src/bin/pg_verifybackup/parse_manifest.c into src/common. > > This makes it possible for the code to be easily reused by other > client-side tools, and/or by the server. > > Patch by me. Review of this patch in particular by at least Peter > Eisentraut; reviewers for the patch series in general include Dilip > Kumar, Andres Fruend, David Steele, Álvaro Herrera, and Jakub Wartak. Worth noting that this has forgotten to update @pgcommonallfiles in Mkvcbuild.pm so this would have failed a build with src/build/msvc/. Or you counted on me here, relying on the scripts to be gone? ;p -- Michael