Thread: Remove unnecessary includes of system headers in header files
I noticed that some header files included system header files for no apparent reason, so I did some digging and found out that in a few cases the original reason has disappeared. So I propose the attached patches to remove the unnecessary includes.
Attachment
RE: Remove unnecessary includes of system headers in header files
From
"Shubham.Khanna@fujitsu.com"
Date:
Hi Peter, I have reviewed the patches and also RUN the command, 'make check-world'. It is working fine. All test cases are passed successfully. Thanks and Regards, Shubham Khanna. -----Original Message----- From: Peter Eisentraut <peter@eisentraut.org> Sent: Friday, December 1, 2023 1:24 PM To: pgsql-hackers <pgsql-hackers@postgresql.org> Subject: Remove unnecessary includes of system headers in header files I noticed that some header files included system header files for no apparent reason, so I did some digging and found outthat in a few cases the original reason has disappeared. So I propose the attached patches to remove the unnecessaryincludes.
Peter Eisentraut <peter@eisentraut.org> writes: > I noticed that some header files included system header files for no > apparent reason, so I did some digging and found out that in a few cases > the original reason has disappeared. So I propose the attached patches > to remove the unnecessary includes. Seems generally reasonable. Have you checked that headerscheck and cpluspluscheck are happy? regards, tom lane
On 01.12.23 17:41, Tom Lane wrote: > Peter Eisentraut <peter@eisentraut.org> writes: >> I noticed that some header files included system header files for no >> apparent reason, so I did some digging and found out that in a few cases >> the original reason has disappeared. So I propose the attached patches >> to remove the unnecessary includes. > > Seems generally reasonable. Have you checked that headerscheck and > cpluspluscheck are happy? Yes, I ran it through Cirrus, which includes those checks.
On 01.12.23 11:51, Shubham.Khanna@fujitsu.com wrote: > Hi Peter, > > I have reviewed the patches and also RUN the command, 'make check-world'. It is working fine. All test cases are passedsuccessfully. committed > > Thanks and Regards, > Shubham Khanna. > > -----Original Message----- > From: Peter Eisentraut <peter@eisentraut.org> > Sent: Friday, December 1, 2023 1:24 PM > To: pgsql-hackers <pgsql-hackers@postgresql.org> > Subject: Remove unnecessary includes of system headers in header files > > I noticed that some header files included system header files for no apparent reason, so I did some digging and found outthat in a few cases the original reason has disappeared. So I propose the attached patches to remove the unnecessaryincludes.