Thread: Add resource intensiveness as a reason to not running tests by default
Hi, With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking' as default because it is resource intensive; but regress docs doesn't state resource intensiveness as a reason for not running tests by default. So, I created a patch for updating the docs. Any kind of feedback would be appreciated. Regards, Nazir Bilal Yavuz Microsoft
Attachment
Re: Add resource intensiveness as a reason to not running tests by default
From
Daniel Gustafsson
Date:
> On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote: > With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking' > as default because it is resource intensive; but regress docs doesn't > state resource intensiveness as a reason for not running tests by > default. So, I created a patch for updating the docs. Agreed, the current wording lacks the mention of skipping tests due to high resource usage. Patch looks good from a quick skim, I'll backpatch it down to 15 which is where PG_TEST_EXTRA was first used in this capacity. -- Daniel Gustafsson
Re: Add resource intensiveness as a reason to not running tests by default
From
Daniel Gustafsson
Date:
> On 7 Sep 2023, at 13:24, Daniel Gustafsson <daniel@yesql.se> wrote: > >> On 7 Sep 2023, at 13:09, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote: > >> With f47ed79cc8, the test suite doesn't run 'wal_consistency_checking' >> as default because it is resource intensive; but regress docs doesn't >> state resource intensiveness as a reason for not running tests by >> default. So, I created a patch for updating the docs. > > Agreed, the current wording lacks the mention of skipping tests due to high > resource usage. Patch looks good from a quick skim, I'll backpatch it down to > 15 which is where PG_TEST_EXTRA was first used in this capacity. Pushed and backpatched, thanks! -- Daniel Gustafsson