Thread: subscription/033_run_as_table_owner is not listed in the meson.build
subscription/033_run_as_table_owner is not listed in the meson.build
From
"Hayato Kuroda (Fujitsu)"
Date:
Dear hackers, I have noticed that the testcase subscription/033_run_as_table_owner in the subscription is not executed when meson build system is chosen. The case is not listed in the meson.build. Do we have any reasons or backgrounds about it? PSA the patch to add the case. It works well on my env. Best Regards, Hayato Kuroda FUJITSU LIMITED
Attachment
On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote: > I have noticed that the testcase subscription/033_run_as_table_owner in the > subscription is not executed when meson build system is chosen. The case is not > listed in the meson.build. > > Do we have any reasons or backgrounds about it? > PSA the patch to add the case. It works well on my env. Seems like a thinko of 4826759 to me, that's easy to miss. Will fix in a bit.. -- Michael
Attachment
On Thu, Jun 15, 2023 at 5:04 PM Michael Paquier <michael@paquier.xyz> wrote: > > On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote: > > I have noticed that the testcase subscription/033_run_as_table_owner in the > > subscription is not executed when meson build system is chosen. The case is not > > listed in the meson.build. > > > > Do we have any reasons or backgrounds about it? > > PSA the patch to add the case. It works well on my env. > > Seems like a thinko of 4826759 to me, that's easy to miss. Will fix > in a bit.. Good catch. Checking similar oversights, src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be listed in meson.build too. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Thu, Jun 15, 2023 at 5:04 PM Michael Paquier <michael@paquier.xyz> wrote: > > > > On Thu, Jun 15, 2023 at 07:16:06AM +0000, Hayato Kuroda (Fujitsu) wrote: > > > I have noticed that the testcase subscription/033_run_as_table_owner in the > > > subscription is not executed when meson build system is chosen. The case is not > > > listed in the meson.build. > > > > > > Do we have any reasons or backgrounds about it? > > > PSA the patch to add the case. It works well on my env. > > > > Seems like a thinko of 4826759 to me, that's easy to miss. Will fix > > in a bit.. > > Good catch. > > Checking similar oversights, > src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be > listed in meson.build too. Here is the patch for that. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
Attachment
On Fri, Jun 16, 2023 at 07:15:36AM +0900, Masahiko Sawada wrote: > On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: >> Checking similar oversights, >> src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be >> listed in meson.build too. > > Here is the patch for that. Yes, good catch. -- Michael
Attachment
On Fri, Jun 16, 2023 at 7:42 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Fri, Jun 16, 2023 at 07:15:36AM +0900, Masahiko Sawada wrote: > > On Thu, Jun 15, 2023 at 5:32 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > >> Checking similar oversights, > >> src/bin/pg_basebackup/t/011_in_place_tablespace.pl seems not to be > >> listed in meson.build too. > > > > Here is the patch for that. > > Yes, good catch. Pushed. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com