Postgres Pro
Downloads
Home   >   mailing lists

Thread: Doc updates for MERGE

Doc updates for MERGE

From
Dean Rasheed
Date:
Attached is a patch fixing a few doc omissions for MERGE.

I don't think that it's necessary to update every place that could
possibly apply to MERGE, but there are a few places where we give a
list of commands that may be used in a particular context, and I think
those should mention MERGE, if it applies.

Also, there were a couple of other places where it seemed worth giving
slightly more detail about what happens for MERGE.

Regards,
Dean
Attachment

Re: Doc updates for MERGE

From
Alvaro Herrera
Date:
On 2023-Feb-24, Dean Rasheed wrote:

> Attached is a patch fixing a few doc omissions for MERGE.
> 
> I don't think that it's necessary to update every place that could
> possibly apply to MERGE, but there are a few places where we give a
> list of commands that may be used in a particular context, and I think
> those should mention MERGE, if it applies.

Agreed.  Your patch looks good to me.

I was confused for a bit about arch-dev.sgml talking about ModifyTable
when perform.sgml talks about Insert/Update et al; I thought at first
that one or the other was in error, so I checked.  It turns out that
they are both correct, because arch-dev is talking about code-level
executor nodes while perform.sgml is talking about how it looks under
EXPLAIN.  So, it all looks good.

I assume you're proposing to back-patch this.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La verdad no siempre es bonita, pero el hambre de ella sí"

Re: Doc updates for MERGE

From
Dean Rasheed
Date:
On Fri, 24 Feb 2023 at 08:56, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> Agreed.  Your patch looks good to me.
>
> I was confused for a bit about arch-dev.sgml talking about ModifyTable
> when perform.sgml talks about Insert/Update et al; I thought at first
> that one or the other was in error, so I checked.  It turns out that
> they are both correct, because arch-dev is talking about code-level
> executor nodes while perform.sgml is talking about how it looks under
> EXPLAIN.  So, it all looks good.
>

Cool. Thanks for checking.

> I assume you're proposing to back-patch this.
>

Yes. Will do.

Regards,
Dean

Re: Doc updates for MERGE

From
Dean Rasheed
Date:
On Fri, 24 Feb 2023 at 09:28, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> On Fri, 24 Feb 2023 at 08:56, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> >
> > I assume you're proposing to back-patch this.
>
> Yes. Will do.
>

Done.

Regards,
Dean