Thread: Get rid of PgStat_BackendFunctionEntry
Hi hackers, Please find attached a patch proposal to $SUBJECT: it would allow to simplify even more the work done to generate pg_stat_get_xact*() functions with Macros. This is a follow up for [1] where it has been suggested to get rid of PgStat_BackendFunctionEntry in a separate patch. Looking forward to your feedback, Regards -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com [1]: https://www.postgresql.org/message-id/20230210214619.bdpbd5wvxcpx27rw%40awork3.anarazel.de
Attachment
On Mon, Feb 13, 2023 at 10:06:27AM +0100, Drouvot, Bertrand wrote: > Please find attached a patch proposal to $SUBJECT: it would allow to simplify > even more the work done to generate pg_stat_get_xact*() functions with Macros. > > This is a follow up for [1] where it has been suggested > to get rid of PgStat_BackendFunctionEntry in a separate patch. Looks reasonable to me. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
On Wed, Mar 08, 2023 at 01:38:38PM -0800, Nathan Bossart wrote: > Looks reasonable to me. I have been catching up with this thread and the other thread, and indeed it looks like this is going to help in refactoring pgstatfuncs.c to have more macros for all these mostly-duplicated functions. So, I have applied this bit. -- Michael
Attachment
Hi, On 3/16/23 6:25 AM, Michael Paquier wrote: > On Wed, Mar 08, 2023 at 01:38:38PM -0800, Nathan Bossart wrote: >> Looks reasonable to me. > > I have been catching up with this thread and the other thread, and > indeed it looks like this is going to help in refactoring > pgstatfuncs.c to have more macros for all these mostly-duplicated > functions. So, I have applied this bit. Thanks! Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com