Thread: windows/meson cfbot warnings
Since a few days ago, the windows/meson task has been spewing messages for each tap test: | Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming version 12. I guess because the image is updated to use meson v1.0.0. https://github.com/mesonbuild/meson/commit/b7a5c384a1f1ba80c09904e7ef4f5160bdae3345 mesonbuild/mtest.py- if version is None: mesonbuild/mtest.py: self.warnings.append('Unknown TAP version. The first line MUST be `TAP version <int>`. Assumingversion 12.') mesonbuild/mtest.py- version = 12 -- Justin
Hi, On 2022-12-28 18:35:38 -0600, Justin Pryzby wrote: > Since a few days ago, the windows/meson task has been spewing messages for each tap > test: > > | Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming version 12. > > I guess because the image is updated to use meson v1.0.0. > https://github.com/mesonbuild/meson/commit/b7a5c384a1f1ba80c09904e7ef4f5160bdae3345 > > mesonbuild/mtest.py- if version is None: > mesonbuild/mtest.py: self.warnings.append('Unknown TAP version. The first line MUST be `TAP version <int>`.Assuming version 12.') > mesonbuild/mtest.py- version = 12 I think the change is somewhat likely to be reverted in the next meson minor version. It apparently came about due to somewhat odd language in the tap-14 spec... So I think we should just wait for now. Greetings, Andres Freund
Hi, On 2022-12-28 17:44:47 -0800, Andres Freund wrote: > On 2022-12-28 18:35:38 -0600, Justin Pryzby wrote: > > Since a few days ago, the windows/meson task has been spewing messages for each tap > > test: > > > > | Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming version 12. > > > > I guess because the image is updated to use meson v1.0.0. > > https://github.com/mesonbuild/meson/commit/b7a5c384a1f1ba80c09904e7ef4f5160bdae3345 > > > > mesonbuild/mtest.py- if version is None: > > mesonbuild/mtest.py: self.warnings.append('Unknown TAP version. The first line MUST be `TAP version <int>`.Assuming version 12.') > > mesonbuild/mtest.py- version = 12 > > I think the change is somewhat likely to be reverted in the next meson minor > version. It apparently came about due to somewhat odd language in the tap-14 > spec... So I think we should just wait for now. FWIW, that did happen in 1.0.1, and the output is now clean again. Greetings, Andres Freund
On Sat, Feb 25, 2023 at 10:29:33AM -0800, Andres Freund wrote: > Hi, > > On 2022-12-28 17:44:47 -0800, Andres Freund wrote: > > On 2022-12-28 18:35:38 -0600, Justin Pryzby wrote: > > > Since a few days ago, the windows/meson task has been spewing messages for each tap > > > test: > > > > > > | Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming version 12. > > > > > > I guess because the image is updated to use meson v1.0.0. > > > https://github.com/mesonbuild/meson/commit/b7a5c384a1f1ba80c09904e7ef4f5160bdae3345 > > > > > > mesonbuild/mtest.py- if version is None: > > > mesonbuild/mtest.py: self.warnings.append('Unknown TAP version. The first line MUST be `TAP version <int>`.Assuming version 12.') > > > mesonbuild/mtest.py- version = 12 > > > > I think the change is somewhat likely to be reverted in the next meson minor > > version. It apparently came about due to somewhat odd language in the tap-14 > > spec... So I think we should just wait for now. > > FWIW, that did happen in 1.0.1, and the output is now clean again. Unrelated, but something else changed and now there's this. https://cirrus-ci.com/task/6202242768830464 [20:10:34.310] c:\cirrus>call sh -c 'if grep ": warning " build.txt; then exit 1; fi; exit 0' [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition
Hi, On 2023-02-25 16:45:38 -0600, Justin Pryzby wrote: > Unrelated, but something else changed and now there's this. > > https://cirrus-ci.com/task/6202242768830464 > > [20:10:34.310] c:\cirrus>call sh -c 'if grep ": warning " build.txt; then exit 1; fi; exit 0' > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition Hm, odd. There's a bit more context about the warning in the output: [21:43:58.782] [1509/2165] Compiling C object src/pl/plpython/plpython3.dll.p/plpy_exec.c.obj [21:43:58.782] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition [21:43:58.924] src/pl/plpython/plpython3.dll.p/meson_pch-c.c: note: see previous definition of 'MS_WIN64' I suspect one would have to look at the external source files to find where it's also defined. The way the warning is triggered it seems to have to be predefined somewhere in/below postgres.h. It might be that we'll get more information after disabling precompiled headers. Greetings, Andres Freund
On Sun, Feb 26, 2023 at 09:54:25AM -0800, Andres Freund wrote: > On 2023-02-25 16:45:38 -0600, Justin Pryzby wrote: > > Unrelated, but something else changed and now there's this. > > > > https://cirrus-ci.com/task/6202242768830464 > > > > [20:10:34.310] c:\cirrus>call sh -c 'if grep ": warning " build.txt; then exit 1; fi; exit 0' > > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > > [20:10:34.397] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > > Hm, odd. > > There's a bit more context about the warning in the output: > > [21:43:58.782] [1509/2165] Compiling C object src/pl/plpython/plpython3.dll.p/plpy_exec.c.obj > [21:43:58.782] C:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition > [21:43:58.924] src/pl/plpython/plpython3.dll.p/meson_pch-c.c: note: see previous definition of 'MS_WIN64' I don't remember right now what I did to get the output, but it's like: [18:33:22.351] c:\python\Include\pyconfig.h(117): warning C4005: 'MS_WIN64': macro redefinition [18:33:22.351] c:\python\Include\pyconfig.h(117): note: 'MS_WIN64' previously declared on the command line I found that this is caused by changes in meson between 1.0.0 and 1.0.1. Probably one of these. https://github.com/mesonbuild/meson/commit/aa69cf04484309f82d2da64c433539d2f6f2fa82 https://github.com/mesonbuild/meson/commit/9bf718fcee0d9e30b5de2d6a2f154aa417aa8d4c -- Justin