Thread: pgsql: Fix some incorrectness in upgrade_adapt.sql on query for WITH OI

Fix some incorrectness in upgrade_adapt.sql on query for WITH OIDS

The query used to disable WITH OIDS in all the relations making use of
it was checking for materialized views, but this is not a supported
operation.  On the contrary, this needs to be done on foreign tables.

While on it, use quote_ident() in the ALTER TABLE strings built on the
relation name.

Author: Anton A. Melnikov, Michael Paquier
Discussion: https://postgr.es/m/49f389ba-95ce-8a9b-09ae-f60650c0e7c7@inbox.ru
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a2688c4e0329687ca5105b7647bbff6bbe33cca4

Modified Files
--------------
src/bin/pg_upgrade/upgrade_adapt.sql | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)