Thread: pgsql: Fix failure to advance content pointer in sendFileWithContent.

pgsql: Fix failure to advance content pointer in sendFileWithContent.

From
Robert Haas
Date:
Fix failure to advance content pointer in sendFileWithContent.

If sendFileWithContent were used to send a file larger than the
bbsink buffer size, this would result in corruption. The only
files that are sent via sendFileWithContent are the backup label
file, the tablespace map file, and .done files for WAL segments
included in the backup. Of these, it seems that only the
tablespace_map file can become large enough to cause a problem,
and then only if you have a lot of tablespaces. If you do have
that situation, you might end up with a corrupted
tablespace_map file, which would be bad.

My commit bef47ff85df18bf4a3a9b13bd2a54820e27f3614 introduced
this problem.

Report and patch by Antonin Houska.

Discussion: http://postgr.es/m/15764.1670528645@antos

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/45f5c81ad2bc2cd4e6a4fa0ba13b34f5c6048d44

Modified Files
--------------
src/backend/backup/basebackup.c | 1 +
1 file changed, 1 insertion(+)