Thread: Re: [RFC] building postgres with meson - v13

On 2022-Sep-25, Andres Freund wrote:

> From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> From: Andres Freund <andres@anarazel.de>
> Date: Wed, 21 Sep 2022 11:03:07 -0700
> Subject: [PATCH v16 04/16] meson: Add windows resource files

> diff --git a/src/backend/jit/llvm/meson.build b/src/backend/jit/llvm/meson.build
> index de2e624ab58..5fb63768358 100644
> --- a/src/backend/jit/llvm/meson.build
> +++ b/src/backend/jit/llvm/meson.build
> @@ -20,6 +20,12 @@ llvmjit_sources += files(
>    'llvmjit_expr.c',
>  )
>  
> +if host_system == 'windows'
> +  llvmjit_sources += rc_lib_gen.process(win32ver_rc, extra_args: [
> +    '--NAME', 'llvmjit',
> +    '--FILEDESC', 'llvmjit - JIT using LLVM',])
> +endif

This is tediously imperative.  Isn't there a more declarative way to
have it?

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Pensar que el espectro que vemos es ilusorio no lo despoja de espanto,
sólo le suma el nuevo terror de la locura" (Perelandra, C.S. Lewis)

Hi,

On 2022-09-26 10:41:01 +0200, Alvaro Herrera wrote:
> On 2022-Sep-25, Andres Freund wrote:
> 
> > From 3eb0ca196084da314d94d1e51c7b775012a4773c Mon Sep 17 00:00:00 2001
> > From: Andres Freund <andres@anarazel.de>
> > Date: Wed, 21 Sep 2022 11:03:07 -0700
> > Subject: [PATCH v16 04/16] meson: Add windows resource files
> 
> > diff --git a/src/backend/jit/llvm/meson.build b/src/backend/jit/llvm/meson.build
> > index de2e624ab58..5fb63768358 100644
> > --- a/src/backend/jit/llvm/meson.build
> > +++ b/src/backend/jit/llvm/meson.build
> > @@ -20,6 +20,12 @@ llvmjit_sources += files(
> >    'llvmjit_expr.c',
> >  )
> >  
> > +if host_system == 'windows'
> > +  llvmjit_sources += rc_lib_gen.process(win32ver_rc, extra_args: [
> > +    '--NAME', 'llvmjit',
> > +    '--FILEDESC', 'llvmjit - JIT using LLVM',])
> > +endif
> 
> This is tediously imperative.  Isn't there a more declarative way to
> have it?

I tried to come up with something better, without success. I think it's
acceptable, even if not great.

Greetings,

Andres Freund