Postgres Pro
Downloads
Home   >   mailing lists

Thread: src/test/perl/PostgreSQL/Test/*.pm not installed

src/test/perl/PostgreSQL/Test/*.pm not installed

From
Alvaro Herrera
Date:
I noticed that the new Perl test modules are not installed, so if you
try to use PostgreSQL/Test/Cluster.pm in an external test from pgxs, it
fails with the modules not being found.

I see no reason for this other than having overseen it in b235d41d9646,
so I propose the attached (for all branches, naturally.)

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La gente vulgar sólo piensa en pasar el tiempo;
el que tiene talento, en aprovecharlo"
Attachment

Re: src/test/perl/PostgreSQL/Test/*.pm not installed

From
Tom Lane
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I noticed that the new Perl test modules are not installed, so if you
> try to use PostgreSQL/Test/Cluster.pm in an external test from pgxs, it
> fails with the modules not being found.
> I see no reason for this other than having overseen it in b235d41d9646,
> so I propose the attached (for all branches, naturally.)

+1, but I suppose you need some adjustment in the meson.build files
now too.

(Also, please wait for the v15 release freeze to lift.)

            regards, tom lane

Re: src/test/perl/PostgreSQL/Test/*.pm not installed

From
Alvaro Herrera
Date:
On 2022-Oct-10, Tom Lane wrote:

> +1, but I suppose you need some adjustment in the meson.build files
> now too.

Oh, right, I forgot ...

> (Also, please wait for the v15 release freeze to lift.)

... and now that I look, it turns out that 15 and master need no
changes: both the Makefile and the meson files are correct already.
Only 14 and back have this problem.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/

Re: src/test/perl/PostgreSQL/Test/*.pm not installed

From
Tom Lane
Date:
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Only 14 and back have this problem.

Ah, cool.  There's no freeze on those branches ...

            regards, tom lane

Re: src/test/perl/PostgreSQL/Test/*.pm not installed

From
Michael Paquier
Date:
On Mon, Oct 10, 2022 at 11:34:15AM +0200, Alvaro Herrera wrote:
> I noticed that the new Perl test modules are not installed, so if you
> try to use PostgreSQL/Test/Cluster.pm in an external test from pgxs, it
> fails with the modules not being found.
>
> I see no reason for this other than having overseen it in b235d41d9646,
> so I propose the attached (for all branches, naturally.)

+1, good catch.  The patch looks fine.
--
Michael
Attachment