Thread: pgsql: windows: Set UMDF_USING_NTSTATUS globally, include ntstatus.h
windows: Set UMDF_USING_NTSTATUS globally, include ntstatus.h We'd like to use precompiled headers on windows to reduce compile times. Right now we rely on defining UMDF_USING_NTSTATUS before including postgres.h in a few select places - which doesn't work with precompiled headers. Instead define it globally. When UMDF_USING_NTSTATUS is defined we need to explicitly include ntstatus.h, winternl.h to get a comparable set of symbols. Right now these includes would be required in a number of non-platform-specific .c files - to avoid that, include them in win32_port.h. Based on my measurements that doesn't increase compile times measurably. Reviewed-by: Thomas Munro <thomas.munro@gmail.com> Discussion: https://postgr.es/m/20220927011951.j3h4o7n6bhf7dwau@awork3.anarazel.de Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/b8d8a4593a3a2daa5e16e4a3634d9284fe14667f Modified Files -------------- src/include/port/win32_port.h | 9 +++++++++ src/include/port/win32ntdll.h | 6 ------ src/port/open.c | 2 -- src/port/win32fdatasync.c | 2 -- src/port/win32ntdll.c | 2 -- src/port/win32stat.c | 2 -- 6 files changed, 9 insertions(+), 14 deletions(-)