Thread: Fix typos in code comments

Fix typos in code comments

From
"houzj.fnst@fujitsu.com"
Date:
Hi,

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.

Best regards,
Hou zhijie


Attachment

Re: Fix typos in code comments

From
Amit Kapila
Date:
On Mon, Sep 19, 2022 at 8:14 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.
>

Thanks, the patch looks good to me. I'll push this.

-- 
With Regards,
Amit Kapila.



Re: Fix typos in code comments

From
Zhang Mingli
Date:
Hi
On Sep 19, 2022, 10:57 +0800, Amit Kapila <amit.kapila16@gmail.com>, wrote:
On Mon, Sep 19, 2022 at 8:14 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:

While working on some other patches, I found serval typos(duplicate words and
incorrect function name reference) in the code comments. Here is a small patch
to fix them.


Thanks, the patch looks good to me. I'll push this.

--
With Regards,
Amit Kapila.


Good catch. There is a similar typo in doc, runtime.sgml.

```using TLS protocols enabled by by setting the parameter```

Re: Fix typos in code comments

From
Justin Pryzby
Date:
On Mon, Sep 19, 2022 at 02:44:12AM +0000, houzj.fnst@fujitsu.com wrote:
> While working on some other patches, I found serval typos(duplicate words and
> incorrect function name reference) in the code comments. Here is a small patch
> to fix them.

Thanks.

On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> Good catch. There is a similar typo in doc, runtime.sgml.
> ```using TLS protocols enabled by by setting the parameter```

That one should be backpatched to v15.

Find below some others.

diff --git a/src/backend/executor/execPartition.c b/src/backend/executor/execPartition.c
index 901dd435efd..160296e1daf 100644
--- a/src/backend/executor/execPartition.c
+++ b/src/backend/executor/execPartition.c
@@ -2155,7 +2155,7 @@ InitPartitionPruneContext(PartitionPruneContext *context,
  * Current values of the indexes present in PartitionPruneState count all the
  * subplans that would be present before initial pruning was done.  If initial
  * pruning got rid of some of the subplans, any subsequent pruning passes will
- * will be looking at a different set of target subplans to choose from than
+ * be looking at a different set of target subplans to choose from than
  * those in the pre-initial-pruning set, so the maps in PartitionPruneState
  * containing those indexes must be updated to reflect the new indexes of
  * subplans in the post-initial-pruning set.
diff --git a/src/backend/utils/activity/pgstat.c b/src/backend/utils/activity/pgstat.c
index 6224c498c21..5b0f26e3b07 100644
--- a/src/backend/utils/activity/pgstat.c
+++ b/src/backend/utils/activity/pgstat.c
@@ -556,7 +556,7 @@ pgstat_initialize(void)
  * suggested idle timeout is returned. Currently this is always
  * PGSTAT_IDLE_INTERVAL (10000ms). Callers can use the returned time to set up
  * a timeout after which to call pgstat_report_stat(true), but are not
- * required to to do so.
+ * required to do so.
  *
  * Note that this is called only when not within a transaction, so it is fair
  * to use transaction stop time as an approximation of current time.
diff --git a/src/backend/utils/activity/pgstat_replslot.c b/src/backend/utils/activity/pgstat_replslot.c
index b77c05ab5fa..9a59012a855 100644
--- a/src/backend/utils/activity/pgstat_replslot.c
+++ b/src/backend/utils/activity/pgstat_replslot.c
@@ -8,7 +8,7 @@
  * storage implementation and the details about individual types of
  * statistics.
  *
- * Replication slot stats work a bit different than other other
+ * Replication slot stats work a bit different than other
  * variable-numbered stats. Slots do not have oids (so they can be created on
  * physical replicas). Use the slot index as object id while running. However,
  * the slot index can change when restarting. That is addressed by using the
diff --git a/src/test/ssl/t/SSL/Server.pm b/src/test/ssl/t/SSL/Server.pm
index 62f54dcbf16..0a9e5da01e4 100644
--- a/src/test/ssl/t/SSL/Server.pm
+++ b/src/test/ssl/t/SSL/Server.pm
@@ -257,7 +257,7 @@ The certificate file to use. Implementation is SSL backend specific.
 
 =item keyfile => B<value>
 
-The private key to to use. Implementation is SSL backend specific.
+The private key file to use. Implementation is SSL backend specific.
 
 =item crlfile => B<value>
 



Re: Fix typos in code comments

From
David Rowley
Date:
On Mon, 19 Sept 2022 at 23:10, Justin Pryzby <pryzby@telsasoft.com> wrote:
> Find below some others.

Thanks. Pushed.

David



Re: Fix typos in code comments

From
Justin Pryzby
Date:
On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > Good catch. There is a similar typo in doc, runtime.sgml.
> > ```using TLS protocols enabled by by setting the parameter```
> 
> That one should be backpatched to v15.

This is still needed -- "by by"

-- 
Justin



Re: Fix typos in code comments

From
Amit Kapila
Date:
On Sat, Sep 24, 2022 at 4:00 AM Justin Pryzby <pryzby@telsasoft.com> wrote:
>
> On Mon, Sep 19, 2022 at 06:10:00AM -0500, Justin Pryzby wrote:
> > On Mon, Sep 19, 2022 at 11:05:24AM +0800, Zhang Mingli wrote:
> > > Good catch. There is a similar typo in doc, runtime.sgml.
> > > ```using TLS protocols enabled by by setting the parameter```
> >
> > That one should be backpatched to v15.
>
> This is still needed -- "by by"
>

Thanks for the reminder. I have pushed the fix.

-- 
With Regards,
Amit Kapila.