Thread: pgsql: Fix race condition in stats.sql added in 5264add7847

Fix race condition in stats.sql added in 5264add7847

Very occasionally the stats test failed due to the number of sessions not
being updated yet. Likely this requires that there is contention on the
database's stats entry. Solve this by forcing pending stats to be flushed
before fetching the stats.

I verified that there are no other test failures after making
pgstat_report_stat() only flush stats when force = true.

Per message from Tom Lane and buildfarm member crake.

Discussion: https://postgr.es/m/3428246.1663271992@sss.pgh.pa.us
Backpatch: 15-, where 5264add7847 added the test

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/885826f95d1c7803d3ff97bde64078b257543266

Modified Files
--------------
src/test/regress/expected/stats.out | 6 ++++++
src/test/regress/sql/stats.sql      | 1 +
2 files changed, 7 insertions(+)