Thread: vacuumlo: add test to vacuumlo for test coverage

Hi hackers,
I write a tiny patch about vacuumlo to improve test coverage.
I hope my work is meaningful.

---
Regards,
DongWook Lee.

> On 3 Sep 2022, at 10:27, Dong Wook Lee <sh95119@gmail.com> wrote:

> I write a tiny patch about vacuumlo to improve test coverage.

If we are paying for setting up a cluster we might as well test more scenarios
than just the one.  Perhaps some other low-hanging fruit like calling vacuumlo
on a non-existing databsase, on one where no LO have been made etc?

One thing about the patch:

+IPC::Run::run [ 'vacuumlo', '-v', '-n', '-p', $port, 'postgres' ], '>', \$stdout;

This should use run_command() which provides facilities for running commands
and capturing STDOUT.  With this the test can be rewritten something like:

my ($out, $err) = run_command(['vacuumlo', .. ]);
like($out, ..);

run_command() is defined in PostgreSQL::Test::Utils.

--
Daniel Gustafsson        https://vmware.com/

2022年9月3日(土) 17:28 Dong Wook Lee <sh95119@gmail.com>:
>
> Hi hackers,
> I write a tiny patch about vacuumlo to improve test coverage.
> I hope my work is meaningful.

Hi

While reviewing the patch backlog, we have determined that this patch adds
one or more TAP tests but has not added the test to the "meson.build" file.

To do this, locate the relevant "meson.build" file for each test and add it
in the 'tests' dictionary, which will look something like this:

  'tap': {
    'tests': [
      't/001_basic.pl',
    ],
  },

For some additional details please see this Wiki article:

  https://wiki.postgresql.org/wiki/Meson_for_patch_authors

For more information on the meson build system for PostgreSQL see:

  https://wiki.postgresql.org/wiki/Meson


Regards

Ian Barwick

On Wed, 16 Nov 2022 at 10:18, Ian Lawrence Barwick <barwick@gmail.com> wrote:
>
> 2022年9月3日(土) 17:28 Dong Wook Lee <sh95119@gmail.com>:
> >
> > Hi hackers,
> > I write a tiny patch about vacuumlo to improve test coverage.
> > I hope my work is meaningful.
>
> Hi
>
> While reviewing the patch backlog, we have determined that this patch adds
> one or more TAP tests but has not added the test to the "meson.build" file.
>
> To do this, locate the relevant "meson.build" file for each test and add it
> in the 'tests' dictionary, which will look something like this:
>
>   'tap': {
>     'tests': [
>       't/001_basic.pl',
>     ],
>   },
>
> For some additional details please see this Wiki article:
>
>   https://wiki.postgresql.org/wiki/Meson_for_patch_authors
>
> For more information on the meson build system for PostgreSQL see:
>
>   https://wiki.postgresql.org/wiki/Meson

Hi DongWook Lee,

Please plan to work on the comment and provide a patch. As CommitFest
2023-01 is currently underway, this would be an excellent time to
update the patch and get the patch in a better shape.

Regards,
Vignesh

On Tue, 17 Jan 2023 at 17:10, vignesh C <vignesh21@gmail.com> wrote:
>
> On Wed, 16 Nov 2022 at 10:18, Ian Lawrence Barwick <barwick@gmail.com> wrote:
> >
> > 2022年9月3日(土) 17:28 Dong Wook Lee <sh95119@gmail.com>:
> > >
> > > Hi hackers,
> > > I write a tiny patch about vacuumlo to improve test coverage.
> > > I hope my work is meaningful.
> >
> > Hi
> >
> > While reviewing the patch backlog, we have determined that this patch adds
> > one or more TAP tests but has not added the test to the "meson.build" file.
> >
> > To do this, locate the relevant "meson.build" file for each test and add it
> > in the 'tests' dictionary, which will look something like this:
> >
> >   'tap': {
> >     'tests': [
> >       't/001_basic.pl',
> >     ],
> >   },
> >
> > For some additional details please see this Wiki article:
> >
> >   https://wiki.postgresql.org/wiki/Meson_for_patch_authors
> >
> > For more information on the meson build system for PostgreSQL see:
> >
> >   https://wiki.postgresql.org/wiki/Meson
>
> Hi DongWook Lee,
>
> Please plan to work on the comment and provide a patch. As CommitFest
> 2023-01 is currently underway, this would be an excellent time to
> update the patch and get the patch in a better shape.

There has been no updates on this thread for some time, so this has
been switched as Returned with Feedback. Feel free to open it in the
next commitfest if you plan to continue on this.

Regards,
Vignesh