Thread: [PATCH] Tab completion for SET COMPRESSION

Hi hackers,

The proposed patch adds the missing tab completion for 'ALTER TABLE
... SET COMPRESSION ...' syntax.

-- 
Best regards,
Aleksander Alekseev

On 2022-08-22 21:48, Aleksander Alekseev wrote:
> Hi hackers,
> 
> The proposed patch adds the missing tab completion for 'ALTER TABLE
> ... SET COMPRESSION ...' syntax.
Thanks, LGTM.

In addition, why not take this opportunity to create a tab completion 
for "ALTER TABLE <name> OF <type_name>" and "ALTER TABLE <name> NOT OF"?


-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

On Tue, Sep 06, 2022 at 09:54:53AM +0900, Shinya Kato wrote:
> In addition, why not take this opportunity to create a tab completion for
> "ALTER TABLE <name> OF <type_name>" and "ALTER TABLE <name> NOT OF"?

Right.  That looks fine to me, so applied.
--
Michael

Hi hackers,

> Right.  That looks fine to me, so applied.

Thanks, Michael.

> In addition, why not take this opportunity to create a tab completion for
> "ALTER TABLE <name> OF <type_name>" and "ALTER TABLE <name> NOT OF"?

Thanks for reviewing, Shinya. Let's fix this too. The patch is attached.

-- 
Best regards,
Aleksander Alekseev

On 2022-09-06 17:28, Aleksander Alekseev wrote:

>> In addition, why not take this opportunity to create a tab completion 
>> for
>> "ALTER TABLE <name> OF <type_name>" and "ALTER TABLE <name> NOT OF"?
> 
> Thanks for reviewing, Shinya. Let's fix this too. The patch is 
> attached.

Thanks for the new patch!
A minor modification has been made so that the composite type is also 
completed after "ALTER TABLE <name> OF".

Thought?

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Hi Shinya,

> A minor modification has been made so that the composite type is also
> completed after "ALTER TABLE <name> OF".

LGTM. Here is v3 created with `git format-path`. Unlike v2 it also
includes the commit message.

-- 
Best regards,
Aleksander Alekseev

On 2022-09-06 20:57, Aleksander Alekseev wrote:
> Hi Shinya,
> 
>> A minor modification has been made so that the composite type is also
>> completed after "ALTER TABLE <name> OF".
> 
> LGTM. Here is v3 created with `git format-path`. Unlike v2 it also
> includes the commit message.

Thanks! I marked it as ready for committer.

-- 
Regards,

--
Shinya Kato
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

On Thu, Sep 08, 2022 at 04:40:32PM +0900, Shinya Kato wrote:
> Thanks! I marked it as ready for committer.

I thought that there was a gotcha in this area for composite types,
but on second look it looks that I was wrong.  Hence, applied.
--
Michael