Thread: [pgAdmin][RM7350] More query tool fixes

Hi Hackers,

Attached patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Hi Hackers,

Please ignore the previous patch. Added one more fix. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Hi Hackers,

Since this is not committed yet. Adding a few more fixes. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then. 

5. NOTICE messages should not be part of Notifier success popups.

Please review.

On Fri, May 6, 2022 at 2:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Please ignore the previous patch. Added one more fix. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Thanks, the patch applied.

On Mon, May 9, 2022 at 11:51 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Since this is not committed yet. Adding a few more fixes. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then. 

5. NOTICE messages should not be part of Notifier success popups.

Please review.

On Fri, May 6, 2022 at 2:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Please ignore the previous patch. Added one more fix. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi,

Attached patch upgrades react-data-grid to latest fork which has fix for grid issues.

On Mon, May 9, 2022 at 12:46 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, the patch applied.

On Mon, May 9, 2022 at 11:51 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Since this is not committed yet. Adding a few more fixes. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

4. Grid not loading more than 10000 rows. react-data-grid issue, PR sent. Use a fork till then. 

5. NOTICE messages should not be part of Notifier success popups.

Please review.

On Fri, May 6, 2022 at 2:39 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Please ignore the previous patch. Added one more fix. Patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

3. Disable execute options when query tool in transaction.

On Fri, May 6, 2022 at 9:58 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached patch fixes:

1. Warning/Confirm dialogs should be inside the query tool.

2. The Help button in View/Edit data should open the corresponding help page.

Please review.

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin Hacker | Software Architect | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"