Thread: "Restore" vs. "Reload"
The following documentation comment has been logged on the website: Page: https://www.postgresql.org/docs/14/backup-dump.html Description: Hello, As far as I can see, the terms "Reload" and "Restore" are used interchangeably. To make the page as easy digestable for the reader as possible, it´s advisable to stick to exactly one term. BR, Axel
On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote: > Page: https://www.postgresql.org/docs/14/backup-dump.html > > As far as I can see, the terms "Reload" and "Restore" are used > interchangeably. > To make the page as easy digestable for the reader as possible, it´s > advisable to stick to exactly one term. That makes sense, particularly since "reload" typically means something else in PostgreSQL. I think "restore" is better. Do you feel like preparing a patch? Yours, Laurenz Albe
On Wed, Mar 16, 2022 at 09:28:04AM +0100, Laurenz Albe wrote: > On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote: > > Page: https://www.postgresql.org/docs/14/backup-dump.html > > > > As far as I can see, the terms "Reload" and "Restore" are used > > interchangeably. > > To make the page as easy digestable for the reader as possible, it´s > > advisable to stick to exactly one term. > > That makes sense, particularly since "reload" typically means something > else in PostgreSQL. I think "restore" is better. > > Do you feel like preparing a patch? I have created the attached patch. The only place I left "reload" was when it was used in pg_dump in "To reload an archive file" and similar cases. In those cases, restoring a script or file might be misinterpreted. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson
Attachment
On Thu, Jul 14, 2022 at 07:42:43PM -0400, Bruce Momjian wrote: > On Wed, Mar 16, 2022 at 09:28:04AM +0100, Laurenz Albe wrote: > > On Tue, 2022-03-15 at 16:12 +0000, PG Doc comments form wrote: > > > Page: https://www.postgresql.org/docs/14/backup-dump.html > > > > > > As far as I can see, the terms "Reload" and "Restore" are used > > > interchangeably. > > > To make the page as easy digestable for the reader as possible, it´s > > > advisable to stick to exactly one term. > > > > That makes sense, particularly since "reload" typically means something > > else in PostgreSQL. I think "restore" is better. > > > > Do you feel like preparing a patch? > > I have created the attached patch. The only place I left "reload" was > when it was used in pg_dump in "To reload an archive file" and similar > cases. In those cases, restoring a script or file might be > misinterpreted. Patch applied back to PG 11. PG 10 had too many conflicts. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com Indecision is a decision. Inaction is an action. Mark Batterson