Thread: pgsql: Fix catalog data of pg_stop_backup(), labelled v2

Fix catalog data of pg_stop_backup(), labelled v2

This function has been incorrectly marked as a set-returning function
with prorows (estimated number of rows) set to 1 since its creation in
7117685, that introduced non-exclusive backups.  There is no need for
that as the function is designed to return only one tuple.

This commit fixes the catalog definition of pg_stop_backup_v2() so as it
is not marked as proretset anymore, with prorows set to 0.  This
simplifies its internals by removing one tuplestore (used for one single
record anyway) and by removing all the checks related to a set-returning
function.

Issue found during my quest to simplify some of the logic used in
in-core system functions.

Bump catalog version.

Reviewed-by: Aleksander Alekseev, Kyotaro Horiguchi
Discussion: https://postgr.es/m/Yh8guT78f1Ercfzw@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/62ce0c758d5d66092efbca7d037233e2ca9bdc78

Modified Files
--------------
src/backend/access/transam/xlogfuncs.c   | 36 ++++++--------------------------
src/backend/catalog/system_functions.sql |  2 +-
src/include/catalog/catversion.h         |  2 +-
src/include/catalog/pg_proc.dat          |  6 +++---
4 files changed, 11 insertions(+), 35 deletions(-)

Michael Paquier <michael@paquier.xyz> writes:
> Fix catalog data of pg_stop_backup(), labelled v2

func.sgml also needs to be fixed, as it says the result
is "setof record".

            regards, tom lane

On Thu, Mar 03, 2022 at 10:09:40AM -0500, Tom Lane wrote:
> func.sgml also needs to be fixed, as it says the result
> is "setof record".

Thanks, fixed.
--
Michael