Thread: [pgAdmin][RM7031]: Database definition wrong

[pgAdmin][RM7031]: Database definition wrong

From
Pradip Parkale
Date:
Hi Hackers,

Please find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment

Re: [pgAdmin][RM7031]: Database definition wrong

From
Akshay Joshi
Date:
Thanks, the patch applied.

On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Re: [pgAdmin][RM7031]: Database definition wrong

From
Aditya Toshniwal
Date:
Hi Pradip,

You did not include the server_old table for query_history. Please also remove the commented code:
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
+    # db.session.commit()
+
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
 


On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][RM7031]: Database definition wrong

From
Pradip Parkale
Date:
Hi Akshay/Aditya,

Please find the updated patch.

On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pradip,

You did not include the server_old table for query_history.
Fixed. 
Please also remove the commented code:
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
+    # db.session.commit()
+
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
Fixed. 
 


On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment

Re: [pgAdmin][RM7031]: Database definition wrong

From
Akshay Joshi
Date:
Thanks, the patch applied.

On Thu, Dec 2, 2021 at 3:09 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay/Aditya,

Please find the updated patch.

On Wed, Dec 1, 2021 at 5:56 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Pradip,

You did not include the server_old table for query_history.
Fixed. 
Please also remove the commented code:
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
+    # db.session.commit()
+
+    # db.engine.execute("PRAGMA foreign_keys=ON")
+
Fixed. 
 


On Wed, Dec 1, 2021 at 5:25 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Wed, Dec 1, 2021 at 4:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached for #7031 Database definition wrong.

--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246