Thread: CREATE PUBLICATION should "See Also" CREATE SUBSCRIPTION
Hi.
I noticed recently that the CREATE PUBLICATION docs page [1] does not
have any "See Also" reference to the CREATE SUBSCRIPTION docs page
[2].
Perhaps it is deliberate (??) but IMO it just seemed like a
strange/annoying omission that there was no easy way to jump both ways
between those two pages.
OTOH, the reverse is OK - the CREATE SUBSCRIPTION docs page *does*
have a "See Also" reference to CREATE PUBLICATION.
Here is a patch:
--- a/doc/src/sgml/ref/create_publication.sgml
+++ b/doc/src/sgml/ref/create_publication.sgml
@@ -333,6 +333,7 @@ CREATE PUBLICATION sales_publication FOR ALL
TABLES IN SCHEMA marketing, sales;
<simplelist type="inline">
<member><xref linkend="sql-alterpublication"/></member>
<member><xref linkend="sql-droppublication"/></member>
+ <member><xref linkend="sql-createsubscription"/></member>
</simplelist>
</refsect1>
</refentry>
------
[1] https://www.postgresql.org/docs/devel/sql-createpublication.html
[2] https://www.postgresql.org/docs/devel/sql-createsubscription.html
Kind Regards,
Peter Smith.
Fujitsu Australia
> On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote: > I noticed recently that the CREATE PUBLICATION docs page [1] does not > have any "See Also" reference to the CREATE SUBSCRIPTION docs page > [2]. Nice catch. > <simplelist type="inline"> > <member><xref linkend="sql-alterpublication"/></member> > <member><xref linkend="sql-droppublication"/></member> > + <member><xref linkend="sql-createsubscription"/></member> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as well. Unless there are objections, I'll apply that. -- Daniel Gustafsson https://vmware.com/
On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson <daniel@yesql.se> wrote: > > > On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote: > > > I noticed recently that the CREATE PUBLICATION docs page [1] does not > > have any "See Also" reference to the CREATE SUBSCRIPTION docs page > > [2]. > > Nice catch. > > > <simplelist type="inline"> > > <member><xref linkend="sql-alterpublication"/></member> > > <member><xref linkend="sql-droppublication"/></member> > > + <member><xref linkend="sql-createsubscription"/></member> > > To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION > reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as > well. +1 Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
> On 17 Nov 2021, at 09:24, Masahiko Sawada <sawada.mshk@gmail.com> wrote: > On Tue, Nov 16, 2021 at 10:21 PM Daniel Gustafsson <daniel@yesql.se> wrote: >> >>> On 15 Nov 2021, at 23:29, Peter Smith <smithpb2250@gmail.com> wrote: >>> <simplelist type="inline"> >>> <member><xref linkend="sql-alterpublication"/></member> >>> <member><xref linkend="sql-droppublication"/></member> >>> + <member><xref linkend="sql-createsubscription"/></member> >> >> To make it analogous with how CREATE/ALTER for SUBSCRIPTION and PUBLICATION >> reference each other, there should IMO be another xref to ALTER SUBSCRIPTION as >> well. > > +1 Pushed, thanks for review! -- Daniel Gustafsson https://vmware.com/
On Wed, Nov 17, 2021 at 11:45 PM Daniel Gustafsson <daniel@yesql.se> wrote: > > Pushed, thanks for review! > Thanks! ------ Kind Regards, Peter Smith. Fujitsu Australia