Postgres Pro
Downloads
Home   >   mailing lists

Thread: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

[PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

From
Célestin Matte
Date:
Hello,

It's only possible to define single IP addresses in the SEARCH_CLIENTS directive (which defines who can use the search
API).This patch allows to use IP ranges such as 0.0.0.0/0.
 
That said, now that I've understood that SEARCH_CLIENTS should contain pgweb server's IP address and not the end user's
one,I'm not entirely sure this patch is useful.
 
It's up for discussion, then.

Cheers,
-- 
Célestin Matte

Re: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

From
Célestin Matte
Date:
Attached
-- 
Célestin Matte
Attachment

Re: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

From
Magnus Hagander
Date:
On Mon, Oct 25, 2021 at 5:25 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
Attached

LGTM. Applied, thanks!
 
--

Re: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

From
Célestin Matte
Date:
It makes sense to do the same thing for API_CLIENTS, a similar variable. See patch attached.
-- 
Célestin Matte
Attachment

Re: [PATCH] pgarchives: Allow use of IP ranges for SEARCH_CLIENTS

From
Magnus Hagander
Date:


On Thu, Nov 4, 2021 at 5:40 PM Célestin Matte <celestin.matte@cmatte.me> wrote:
It makes sense to do the same thing for API_CLIENTS, a similar variable. See patch attached.


Yup, seems reasonable -- I missed that as well in the first submission.

Applied, thanks! 

--