Thread: pgsql: Move Perl test modules to a better namespace

pgsql: Move Perl test modules to a better namespace

From
Andrew Dunstan
Date:
Move Perl test modules to a better namespace

The five modules in our TAP test framework all had names in the top
level namespace. This is unwise because, even though we're not
exporting them to CPAN, the names can leak, for example if they are
exported by the RPM build process. We therefore move the modules to the
PostgreSQL::Test namespace. In the process PostgresNode is renamed to
Cluster, and TestLib is renamed to Utils. PostgresVersion becomes simply
PostgreSQL::Version, to avoid possible confusion about what it's the
version of.

Discussion: https://postgr.es/m/aede93a4-7d92-ef26-398f-5094944c2504@dunslane.net

Reviewed by Erik Rijkers and Michael Paquier

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b3b4d8e68ae83f432f43f035c7eb481ef93e1583

Modified Files
--------------
contrib/amcheck/t/001_verify_heapam.pl             |   6 +-
contrib/amcheck/t/002_cic.pl                       |   6 +-
contrib/amcheck/t/003_cic_2pc.pl                   |   6 +-
contrib/auto_explain/t/001_auto_explain.pl         |   6 +-
contrib/bloom/t/001_wal.pl                         |   8 +-
contrib/oid2name/t/001_basic.pl                    |   2 +-
contrib/test_decoding/t/001_repl_stats.pl          |   6 +-
contrib/vacuumlo/t/001_basic.pl                    |   2 +-
src/bin/initdb/t/001_initdb.pl                     |   6 +-
src/bin/pg_amcheck/t/001_basic.pl                  |   2 +-
src/bin/pg_amcheck/t/002_nonesuch.pl               |   6 +-
src/bin/pg_amcheck/t/003_check.pl                  |   8 +-
src/bin/pg_amcheck/t/004_verify_heapam.pl          |   6 +-
src/bin/pg_amcheck/t/005_opclass_damage.pl         |   6 +-
.../pg_archivecleanup/t/010_pg_archivecleanup.pl   |   4 +-
src/bin/pg_basebackup/t/010_pg_basebackup.pl       |  18 +--
src/bin/pg_basebackup/t/020_pg_receivewal.pl       |   6 +-
src/bin/pg_basebackup/t/030_pg_recvlogical.pl      |   6 +-
src/bin/pg_checksums/t/001_basic.pl                |   2 +-
src/bin/pg_checksums/t/002_actions.pl              |   8 +-
src/bin/pg_config/t/001_pg_config.pl               |   2 +-
src/bin/pg_controldata/t/001_pg_controldata.pl     |   6 +-
src/bin/pg_ctl/t/001_start_stop.pl                 |  14 +-
src/bin/pg_ctl/t/002_status.pl                     |   8 +-
src/bin/pg_ctl/t/003_promote.pl                    |  12 +-
src/bin/pg_ctl/t/004_logrotate.pl                  |   6 +-
src/bin/pg_dump/t/001_basic.pl                     |   6 +-
src/bin/pg_dump/t/002_pg_dump.pl                   |  10 +-
src/bin/pg_dump/t/003_pg_dump_with_server.pl       |   8 +-
src/bin/pg_dump/t/010_dump_connstr.pl              |  16 +--
src/bin/pg_resetwal/t/001_basic.pl                 |   6 +-
src/bin/pg_resetwal/t/002_corrupted.pl             |   6 +-
src/bin/pg_rewind/t/001_basic.pl                   |   2 +-
src/bin/pg_rewind/t/002_databases.pl               |   2 +-
src/bin/pg_rewind/t/003_extrafiles.pl              |   2 +-
src/bin/pg_rewind/t/004_pg_xlog_symlink.pl         |   4 +-
src/bin/pg_rewind/t/005_same_timeline.pl           |   2 +-
src/bin/pg_rewind/t/006_options.pl                 |   6 +-
src/bin/pg_rewind/t/007_standby_source.pl          |  10 +-
src/bin/pg_rewind/t/008_min_recovery_point.pl      |  12 +-
src/bin/pg_rewind/t/RewindTest.pm                  |  14 +-
src/bin/pg_test_fsync/t/001_basic.pl               |   2 +-
src/bin/pg_test_timing/t/001_basic.pl              |   2 +-
src/bin/pg_verifybackup/t/001_basic.pl             |   4 +-
src/bin/pg_verifybackup/t/002_algorithm.pl         |   6 +-
src/bin/pg_verifybackup/t/003_corruption.pl        |  10 +-
src/bin/pg_verifybackup/t/004_options.pl           |   6 +-
src/bin/pg_verifybackup/t/005_bad_manifest.pl      |   6 +-
src/bin/pg_verifybackup/t/006_encoding.pl          |   6 +-
src/bin/pg_verifybackup/t/007_wal.pl               |   6 +-
src/bin/pg_waldump/t/001_basic.pl                  |   2 +-
src/bin/pgbench/t/001_pgbench_with_server.pl       |  14 +-
src/bin/pgbench/t/002_pgbench_no_server.pl         |   4 +-
src/bin/psql/t/001_basic.pl                        |   6 +-
src/bin/psql/t/010_tab_completion.pl               |   8 +-
src/bin/psql/t/020_cancel.pl                       |  10 +-
src/bin/scripts/t/010_clusterdb.pl                 |   6 +-
src/bin/scripts/t/011_clusterdb_all.pl             |   6 +-
src/bin/scripts/t/020_createdb.pl                  |   6 +-
src/bin/scripts/t/040_createuser.pl                |   6 +-
src/bin/scripts/t/050_dropdb.pl                    |   6 +-
src/bin/scripts/t/070_dropuser.pl                  |   6 +-
src/bin/scripts/t/080_pg_isready.pl                |   6 +-
src/bin/scripts/t/090_reindexdb.pl                 |   8 +-
src/bin/scripts/t/091_reindexdb_all.pl             |   4 +-
src/bin/scripts/t/100_vacuumdb.pl                  |   6 +-
src/bin/scripts/t/101_vacuumdb_all.pl              |   4 +-
src/bin/scripts/t/102_vacuumdb_stages.pl           |   4 +-
src/bin/scripts/t/200_connstr.pl                   |   6 +-
src/test/authentication/t/001_password.pl          |   8 +-
src/test/authentication/t/002_saslprep.pl          |   6 +-
src/test/kerberos/t/001_auth.pl                    |  24 ++--
src/test/ldap/t/001_auth.pl                        |  24 ++--
src/test/modules/brin/t/01_workitems.pl            |   6 +-
src/test/modules/commit_ts/t/001_base.pl           |   6 +-
src/test/modules/commit_ts/t/002_standby.pl        |   8 +-
src/test/modules/commit_ts/t/003_standby_2.pl      |   8 +-
src/test/modules/commit_ts/t/004_restart.pl        |   6 +-
.../modules/libpq_pipeline/t/001_libpq_pipeline.pl |  10 +-
.../ssl_passphrase_callback/t/001_testfunc.pl      |   8 +-
.../test_misc/t/001_constraint_validation.pl       |   6 +-
src/test/modules/test_pg_dump/t/001_base.pl        |  10 +-
src/test/perl/Makefile                             |  22 +--
.../Test/Cluster.pm}                               | 154 ++++++++++-----------
.../perl/{ => PostgreSQL/Test}/RecursiveCopy.pm    |  12 +-
src/test/perl/{ => PostgreSQL/Test}/SimpleTee.pm   |   2 +-
.../perl/{TestLib.pm => PostgreSQL/Test/Utils.pm}  |  22 +--
.../{PostgresVersion.pm => PostgreSQL/Version.pm}  |  18 +--
src/test/perl/README                               |   8 +-
src/test/recovery/t/001_stream_rep.pl              |  10 +-
src/test/recovery/t/002_archiving.pl               |  10 +-
src/test/recovery/t/003_recovery_targets.pl        |  12 +-
src/test/recovery/t/004_timeline_switch.pl         |  14 +-
src/test/recovery/t/005_replay_delay.pl            |  10 +-
src/test/recovery/t/006_logical_decoding.pl        |   6 +-
src/test/recovery/t/007_sync_rep.pl                |  14 +-
src/test/recovery/t/008_fsm_truncation.pl          |   8 +-
src/test/recovery/t/009_twophase.pl                |   8 +-
.../recovery/t/010_logical_decoding_timelines.pl   |   8 +-
src/test/recovery/t/011_crash_recovery.pl          |   6 +-
src/test/recovery/t/012_subtransactions.pl         |   8 +-
src/test/recovery/t/013_crash_restart.pl           |  12 +-
src/test/recovery/t/014_unlogged_reinit.pl         |  10 +-
src/test/recovery/t/015_promotion_pages.pl         |   8 +-
src/test/recovery/t/016_min_consistency.pl         |   8 +-
src/test/recovery/t/017_shm.pl                     |  12 +-
src/test/recovery/t/018_wal_optimize.pl            |  12 +-
src/test/recovery/t/019_replslot_limit.pl          |  22 +--
src/test/recovery/t/020_archive_status.pl          |  12 +-
src/test/recovery/t/021_row_visibility.pl          |  10 +-
src/test/recovery/t/022_crash_temp_files.pl        |  12 +-
src/test/recovery/t/023_pitr_prepared_xact.pl      |   8 +-
src/test/recovery/t/024_archive_recovery.pl        |   8 +-
src/test/recovery/t/025_stuck_on_old_timeline.pl   |  16 +--
src/test/recovery/t/026_overwrite_contrecord.pl    |   8 +-
src/test/regress/pg_regress.c                      |   2 +-
src/test/ssl/t/001_ssltests.pl                     |   6 +-
src/test/ssl/t/002_scram.pl                        |   6 +-
src/test/ssl/t/SSLServer.pm                        |   4 +-
src/test/subscription/t/001_rep_changes.pl         |   8 +-
src/test/subscription/t/002_types.pl               |   8 +-
src/test/subscription/t/003_constraints.pl         |   8 +-
src/test/subscription/t/004_sync.pl                |   8 +-
src/test/subscription/t/005_encoding.pl            |   8 +-
src/test/subscription/t/006_rewrite.pl             |   8 +-
src/test/subscription/t/007_ddl.pl                 |   8 +-
src/test/subscription/t/008_diff_schema.pl         |   8 +-
src/test/subscription/t/009_matviews.pl            |   8 +-
src/test/subscription/t/010_truncate.pl            |   8 +-
src/test/subscription/t/011_generated.pl           |   8 +-
src/test/subscription/t/012_collation.pl           |   8 +-
src/test/subscription/t/013_partition.pl           |  10 +-
src/test/subscription/t/014_binary.pl              |   8 +-
src/test/subscription/t/015_stream.pl              |   8 +-
src/test/subscription/t/016_stream_subxact.pl      |   8 +-
src/test/subscription/t/017_stream_ddl.pl          |   8 +-
.../subscription/t/018_stream_subxact_abort.pl     |   8 +-
.../subscription/t/019_stream_subxact_ddl_abort.pl |   8 +-
src/test/subscription/t/020_messages.pl            |   8 +-
src/test/subscription/t/021_twophase.pl            |   8 +-
src/test/subscription/t/022_twophase_cascade.pl    |  10 +-
src/test/subscription/t/023_twophase_stream.pl     |   8 +-
src/test/subscription/t/024_add_drop_pub.pl        |   8 +-
src/test/subscription/t/100_bugs.pl                |  18 +--
144 files changed, 656 insertions(+), 656 deletions(-)