Thread: pgsql: Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURR
Avoid race in RelationBuildDesc() affecting CREATE INDEX CONCURRENTLY. CIC and REINDEX CONCURRENTLY assume backends see their catalog changes no later than each backend's next transaction start. That failed to hold when a backend absorbed a relevant invalidation in the middle of running RelationBuildDesc() on the CIC index. Queries that use the resulting index can silently fail to find rows. Fix this for future index builds by making RelationBuildDesc() loop until it finishes without accepting a relevant invalidation. It may be necessary to reindex to recover from past occurrences; REINDEX CONCURRENTLY suffices. Back-patch to 9.6 (all supported versions). Noah Misch and Andrey Borodin, reviewed (in earlier versions) by Andres Freund. Discussion: https://postgr.es/m/20210730022548.GA1940096@gust.leadboat.com Branch ------ REL_14_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/dde966efb286ddc222f17013a8cf4561a3b67a5e Modified Files -------------- contrib/amcheck/t/002_cic.pl | 78 ++++++++++++++++ src/backend/utils/cache/inval.c | 12 ++- src/backend/utils/cache/relcache.c | 115 +++++++++++++++++++++-- src/bin/pgbench/t/001_pgbench_with_server.pl | 118 +++++++---------------- src/include/utils/inval.h | 1 + src/include/utils/relcache.h | 2 +- src/test/perl/PostgresNode.pm | 134 +++++++++++++++++++++++++++ src/tools/pgindent/typedefs.list | 1 + 8 files changed, 368 insertions(+), 93 deletions(-)