Thread: [pgAdmin][RM6081] Advanced table fields in ERD

[pgAdmin][RM6081] Advanced table fields in ERD

From
Aditya Toshniwal
Date:
Hi Hackers,

Attached patch will port Backbone based dialogs in ERD to React based using the schema view UI framework. This allows us to use the existing table UI, remove repeated code and enable advanced fields. I have hidden fields from the existing table UI for ERD.
Please note, this also fixes #6529.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM6081] Advanced table fields in ERD

From
Akshay Joshi
Date:
Thanks, the patch applied.

On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will port Backbone based dialogs in ERD to React based using the schema view UI framework. This allows us to use the existing table UI, remove repeated code and enable advanced fields. I have hidden fields from the existing table UI for ERD.
Please note, this also fixes #6529.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Re: [pgAdmin][RM6081] Advanced table fields in ERD

From
Aditya Toshniwal
Date:
Hi,

Please review the attached patch to fix failing API test case.

On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will port Backbone based dialogs in ERD to React based using the schema view UI framework. This allows us to use the existing table UI, remove repeated code and enable advanced fields. I have hidden fields from the existing table UI for ERD.
Please note, this also fixes #6529.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Attachment

Re: [pgAdmin][RM6081] Advanced table fields in ERD

From
Akshay Joshi
Date:
Thanks, the patch applied.

On Tue, Oct 12, 2021 at 11:36 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

Please review the attached patch to fix failing API test case.

On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.

On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

Attached patch will port Backbone based dialogs in ERD to React based using the schema view UI framework. This allows us to use the existing table UI, remove repeated code and enable advanced fields. I have hidden fields from the existing table UI for ERD.
Please note, this also fixes #6529.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246