Thread: Better context for "TAP tests not enabled" error message
I got the error message in the subject and was unsure how to continue; I didn't see any hits for the error message on the mailing list, and it was hard to determine from the context around the error in the Makefile.global.in about the best way to solve the problem.
This patch amends the error message to give help to the user.
I ran "make check" at the top level with this patch enabled and 209 tests passed. I also ran "make check" in src/test/ssl without TAP enabled and verified that I got the new error message. I also verified that compiling with --enable-tap-tests fixes the error in question.
This patch does not include regression tests.
Another way to fix this issue could be to put the exact text of the error message in the documentation or the wiki, with instructions on how to fix it - the first thing I did was punch the error message into Google, if a match for the error message came up with instructions on how to fix it, that would also help.
This is the first patch that I've submitted to Postgres, I believe that I've followed the guidelines on the patch submission page, but please let me know if I missed anything.
Kevin
Attachment
> On 2 Oct 2021, at 02:09, Kevin Burke <kevin@burke.dev> wrote: > This patch amends the error message to give help to the user. I think this makes sense, and is in line with Rachels patch [0] a few days ago that I plan on pushing; small error hints which wont get in the way of established developers, but which can help new developers onboard onto our tree and processes around it. -- Daniel Gustafsson https://vmware.com/ [0] https://postgr.es/m/CADJcwiVL20955HCNzDqz9BEDr6A77pz6-nac5sbZVvhAEMijLg@mail.gmail.com
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 2 Oct 2021, at 02:09, Kevin Burke <kevin@burke.dev> wrote:
>> This patch amends the error message to give help to the user.
> I think this makes sense,
+1. I'd take out the "Maybe"; the diagnosis seems pretty certain.
regards, tom lane
Updated patch that removes the "Maybe"
On Sat, Oct 2, 2021 at 11:19 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
Daniel Gustafsson <daniel@yesql.se> writes:
>> On 2 Oct 2021, at 02:09, Kevin Burke <kevin@burke.dev> wrote:
>> This patch amends the error message to give help to the user.
> I think this makes sense,
+1. I'd take out the "Maybe"; the diagnosis seems pretty certain.
regards, tom lane
Attachment
> On 3 Oct 2021, at 00:39, Kevin Burke <kevin@burke.dev> wrote: > Updated patch that removes the "Maybe" Thanks, I’ll take care of this tomorrow along with Rachels patch. ./daniel
> On 3 Oct 2021, at 01:27, Daniel Gustafsson <daniel@yesql.se> wrote: > >> On 3 Oct 2021, at 00:39, Kevin Burke <kevin@burke.dev> wrote: > >> Updated patch that removes the "Maybe" > > Thanks, I’ll take care of this tomorrow along with Rachels patch. I was off-by-one on date, but it's been pushed to master now. Thanks! -- Daniel Gustafsson https://vmware.com/