Thread: Background worker docs,
Why is the last comma there ?
"bgw_restart_time is the interval, in seconds, that postgres should wait before restarting the process, in case it crashes."
diff --git a/doc/src/sgml/bgworker.sgml b/doc/src/sgml/bgworker.sgml
index d34acfc220..6f13006e25 100644
--- a/doc/src/sgml/bgworker.sgml
+++ b/doc/src/sgml/bgworker.sgml
@@ -130,7 +130,7 @@ typedef struct BackgroundWorker
<para>
<structfield>bgw_restart_time</structfield> is the interval, in seconds, that
- <command>postgres</command> should wait before restarting the process, in
+ <command>postgres</command> should wait before restarting the process in
case it crashes. It can be any positive value,
or <literal>BGW_NEVER_RESTART</literal>, indicating not to restart the
process in case of a crash.
Dave Cramer
> On 27 Aug 2021, at 15:17, Dave Cramer <davecramer@gmail.com> wrote: > > Why is the last comma there ? > > "bgw_restart_time is the interval, in seconds, that postgres should wait before restarting the process, in case it crashes." > - <command>postgres</command> should wait before restarting the process, in > + <command>postgres</command> should wait before restarting the process in While not being an native english speaker, I agree that this reads better. -- Daniel Gustafsson https://vmware.com/
On Fri, 27 Aug 2021 at 09:24, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 27 Aug 2021, at 15:17, Dave Cramer <davecramer@gmail.com> wrote:
>
> Why is the last comma there ?
>
> "bgw_restart_time is the interval, in seconds, that postgres should wait before restarting the process, in case it crashes."
> - <command>postgres</command> should wait before restarting the process, in
> + <command>postgres</command> should wait before restarting the process in
While not being an native english speaker, I agree that this reads better.
As a native English speaker, I was left wondering what else the timeout would be used for.
Dave Cramer
Dave Cramer <davecramer@gmail.com> writes:
>> - <command>postgres</command> should wait before restarting the
>> process, in
>> + <command>postgres</command> should wait before restarting the
>> process in
> As a native English speaker, I was left wondering what else the timeout
> would be used for.
Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this
sentence needs more help than just comma-removal.
regards, tom lane
On Fri, 27 Aug 2021 at 09:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Dave Cramer <davecramer@gmail.com> writes:
>> - <command>postgres</command> should wait before restarting the
>> process, in
>> + <command>postgres</command> should wait before restarting the
>> process in
> As a native English speaker, I was left wondering what else the timeout
> would be used for.
Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this
sentence needs more help than just comma-removal.
In my mind "in the event that it crashes" made it clear
regards, tom lane
> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote: > On Fri, 27 Aug 2021 at 09:50, Tom Lane <tgl@sss.pgh.pa.us <mailto:tgl@sss.pgh.pa.us>> wrote: > Maybe s/in case/if/ ? Or s/in case/after/ ? It does seem like this > sentence needs more help than just comma-removal. > > In my mind "in the event that it crashes" made it clear That, or “if it crashes” gets my vote. -- Daniel Gustafsson https://vmware.com/
Daniel Gustafsson <daniel@yesql.se> writes:
> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
>> In my mind "in the event that it crashes" made it clear
> That, or “if it crashes” gets my vote.
Dave's wording sounds good to me.
regards, tom lane
On Fri, 27 Aug 2021 at 10:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Daniel Gustafsson <daniel@yesql.se> writes:
> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote:
>> In my mind "in the event that it crashes" made it clear
> That, or “if it crashes” gets my vote.
Dave's wording sounds good to me.
regards, tom lane
revised diff
Attachment
> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <daniel@yesql.se> writes: >> On 27 Aug 2021, at 15:52, Dave Cramer <davecramer@gmail.com> wrote: >>> In my mind "in the event that it crashes" made it clear > >> That, or “if it crashes” gets my vote. > > Dave's wording sounds good to me. I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim, unless you’re already on it. -- Daniel Gustafsson https://vmware.com/
Daniel Gustafsson <daniel@yesql.se> writes:
> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Dave's wording sounds good to me.
> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim,
> unless you’re already on it.
Feel free, I've got other stuff on my plate right now.
regards, tom lane
> On 27 Aug 2021, at 16:31, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <daniel@yesql.se> writes: >> On 27 Aug 2021, at 16:15, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> Dave's wording sounds good to me. > >> I can go make that happen, backpatched down to 9.6 AFAICT on a quick skim, >> unless you’re already on it. > > Feel free, I've got other stuff on my plate right now. And done, thanks. -- Daniel Gustafsson https://vmware.com/