Thread: [pgAdmin][patch] RM6675 Port package and it’s child node to React

[pgAdmin][patch] RM6675 Port package and it’s child node to React

From
Rahul Shirsat
Date:
Hi Hackers,

Please find the attached patch which ports package and its child nodes to react.

A minor change of fullTab for sql type is added for the Properties tab.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.
Attachment

Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React

From
Akshay Joshi
Date:
Hi Rahul

On Wed, Aug 18, 2021 at 12:31 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which ports package and its child nodes to react.

A minor change of fullTab for sql type is added for the Properties tab.

    The above change broke the visibility of the content of the code mirror in the Properties panel for all the nodes (wherever applicable).
    With your patch select any trigger function, package, edb functions and verify in the Properties panel.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Re: [pgAdmin][patch] RM6675 Port package and it’s child node to React

From
Rahul Shirsat
Date:
Hello Akshay,

My bad. I haven't mentioned that this is a known issue which is mentioned in the "pgAdmin Nodes to React" sheet. So it's a known issue.

Also, the changes on the Properties panel made is for only showing fullTab display for Code mirror wherever applicable.

On Wed, Aug 18, 2021 at 7:55 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Rahul

On Wed, Aug 18, 2021 at 12:31 PM Rahul Shirsat <rahul.shirsat@enterprisedb.com> wrote:
Hi Hackers,

Please find the attached patch which ports package and its child nodes to react.

A minor change of fullTab for sql type is added for the Properties tab.

    The above change broke the visibility of the content of the code mirror in the Properties panel for all the nodes (wherever applicable).
    With your patch select any trigger function, package, edb functions and verify in the Properties panel.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.