Postgres Pro
Downloads
Home   >   mailing lists

Thread: add 'noError' to euc_tw_and_big5.c

add 'noError' to euc_tw_and_big5.c

From
"wangyukun@fujitsu.com"
Date:

Hi, Heikki

 

'noError' argument was added at commit ea1b99a661,

but it seems to be neglected in euc_tw_and_big5.c Line 289.

please see the attachment.

 

Regards,

Yukun Wang

Attachment

Re: add 'noError' to euc_tw_and_big5.c

From
Michael Paquier
Date:
On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> 'noError' argument was added at commit ea1b99a661,
> but it seems to be neglected in euc_tw_and_big5.c Line 289.
> please see the attachment.

That sounds right to me.  Double-checking the area, I am not seeing
another portion of the code to fix.
--
Michael
Attachment

Re: add 'noError' to euc_tw_and_big5.c

From
John Naylor
Date:

On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me.  Double-checking the area, I am not seeing
> another portion of the code to fix.

Agreed, will push.

--
John Naylor
EDB: http://www.enterprisedb.com

Re: add 'noError' to euc_tw_and_big5.c

From
John Naylor
Date:

On Tue, Jul 20, 2021 at 10:35 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jul 21, 2021 at 02:15:14AM +0000, wangyukun@fujitsu.com wrote:
> > 'noError' argument was added at commit ea1b99a661,
> > but it seems to be neglected in euc_tw_and_big5.c Line 289.
> > please see the attachment.
>
> That sounds right to me.  Double-checking the area, I am not seeing
> another portion of the code to fix.

Pushed, but I forgot to give you review credit, sorry about that. Thanks for taking a look!

--
John Naylor
EDB: http://www.enterprisedb.com