Thread: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
Hi all, I realized that we use the magic number 10 instead of PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() function. It seems an oversight of the original commit. Attached patch fixes it. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
Attachment
On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > Hi all, > > I realized that we use the magic number 10 instead of > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() > function. It seems an oversight of the original commit. Attached patch > fixes it. > LGTM. I'll take care of it tomorrow. -- With Regards, Amit Kapila.
On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > Hi all, > > > > I realized that we use the magic number 10 instead of > > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() > > function. It seems an oversight of the original commit. Attached patch > > fixes it. > > > > LGTM. I'll take care of it tomorrow. > Pushed. -- With Regards, Amit Kapila.
Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
From
Masahiko Sawada
Date:
On Wed, Jun 30, 2021 at 5:12 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > > > Hi all, > > > > > > I realized that we use the magic number 10 instead of > > > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot() > > > function. It seems an oversight of the original commit. Attached patch > > > fixes it. > > > > > > > LGTM. I'll take care of it tomorrow. > > > > Pushed. Thanks! Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/