Thread: Some incorrect logs in TAP tests of pgbench
Hi all, While digging into some of the TAP tests, I have noticed that 002_pgbench_no_server.pl prints array pointers, like that: opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990), err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running: pgbench -f no-such-file I am a bit dubious that this information is useful when it comes to debugging because we have the name of the tests close by, so I would just remove those extra logs. If people prefer keeping this information around, we could fix the format with something like the attached, for example. Thoughts? -- Michael
Attachment
On 6/25/21 8:33 AM, Michael Paquier wrote: > Hi all, > > While digging into some of the TAP tests, I have noticed that > 002_pgbench_no_server.pl prints array pointers, like that: > opts=-f no-such-file, stat=1, out=ARRAY(0x1374d7990), > err=ARRAY(0x14028dc40), name=pgbench option error: no file# Running: > pgbench -f no-such-file > > I am a bit dubious that this information is useful when it comes to > debugging because we have the name of the tests close by, so I would > just remove those extra logs. If people prefer keeping this > information around, we could fix the format with something like the > attached, for example. > > Thoughts? Either that or dereference them, by printing @$out and @$err instead of $out and $err or something similar. But probably the name of the test is sufficient. (What were we thinking in allowing this in the first place?) cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
On 2021-Jun-25, Michael Paquier wrote: > I am a bit dubious that this information is useful when it comes to > debugging because we have the name of the tests close by, so I would > just remove those extra logs. If people prefer keeping this > information around, we could fix the format with something like the > attached, for example. I agree it's not useful -- command_checks_all logs each element of those arrays already, when doing its like(). So ISTM we can do away with them. -- Álvaro Herrera 39°49'30"S 73°17'W "Most hackers will be perfectly comfortable conceptualizing users as entropy sources, so let's move on." (Nathaniel Smith)
On Fri, Jun 25, 2021 at 09:37:50AM -0400, Andrew Dunstan wrote: > Either that or dereference them, by printing @$out and @$err instead of > $out and $err or something similar. Looking again, we don't really lose context if we remove that, so done this way. > But probably the name of the test is sufficient. (What were we thinking > in allowing this in the first place?) No idea. This got introduced in v5 of what got committed as of ed8a7c6: https://www.postgresql.org/message-id/alpine.DEB.2.20.1705091641150.29373@lancre -- Michael
Attachment
> (What were we thinking in allowing this in the first place?) Temporary debug leftovers that got through, I'd say. Thanks Michaël for the clean up! -- Fabien.