Thread: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up
Hi Hackers,
Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.
Server configuration won't be visible to the non-admin users in server mode.
-- Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Software Engineer | EnterpriseDB Corporation
Attachment
Hi Pradip
. 
Following are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.


On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246
Attachment
Hi Akshay,
Please find an updated patch.
On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done.
.
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Software Engineer | EnterpriseDB Corporation
Attachment
Thanks, patch applied.
On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246
Attachment
Hi Akshay,
Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.
On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Software Engineer | EnterpriseDB Corporation
Attachment
Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up
From
Murtuza Zabuawala
Date:
Hello,
I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP
SMTP
- config1=value1
- config2=value2
- config3=value3 ...
- config2=value2
- config3=value3 ...
AUTHENTICATION
- KERBERSOE
- config1=value1
- config2=value2
- config3=value3 ...
- config2=value2
- config3=value3 ...
- LDAP
- config1=value1
- config2=value2
- config3=value3 ...
SECURITY
- config2=value2
- config3=value3 ...
SECURITY
- config1=value1
- config2=value2
- config3=value3 ...
- config2=value2
- config3=value3 ...
Regards,
Murtuza
Murtuza
On Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Attachment
Hi
On Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...
It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.
Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Dave Page
VP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Attachment
Re: [pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up
From
Murtuza Zabuawala
Date:
Hi Dave,
On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:
HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.
If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.
Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Attachment
On Fri, Jun 4, 2021 at 3:14 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi Dave,On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.
It's still useful to read it occasionally IMHO.
Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Dave Page
VP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Attachment
Hi Akshay,
Please find the attached patch for #6231.I have fixed all review comments given in the team.
On Fri, Jun 4, 2021 at 8:09 PM Dave Page <dave.page@enterprisedb.com> wrote:
On Fri, Jun 4, 2021 at 3:14 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.It's still useful to read it occasionally IMHO.Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Software Engineer | EnterpriseDB Corporation
Attachment
Thanks, the patch applied.
On Fri, Jun 11, 2021 at 7:20 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,Please find the attached patch for #6231.I have fixed all review comments given in the team.On Fri, Jun 4, 2021 at 8:09 PM Dave Page <dave.page@enterprisedb.com> wrote:On Fri, Jun 4, 2021 at 3:14 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.It's still useful to read it occasionally IMHO.Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246
Attachment
Hi Akshay,
Please find the attached patch.'Mail_Password' was visible in server configuration.I removed that now.
On Fri, Jun 11, 2021 at 7:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Thanks, the patch applied.On Fri, Jun 11, 2021 at 7:20 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the attached patch for #6231.I have fixed all review comments given in the team.On Fri, Jun 4, 2021 at 8:09 PM Dave Page <dave.page@enterprisedb.com> wrote:On Fri, Jun 4, 2021 at 3:14 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.It's still useful to read it occasionally IMHO.Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246
Thanks & Regards,
Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Software Engineer | EnterpriseDB Corporation
Attachment
Thanks, the patch applied.
On Thu, Jun 24, 2021 at 9:04 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:
Hi Akshay,Please find the attached patch.'Mail_Password' was visible in server configuration.I removed that now.On Fri, Jun 11, 2021 at 7:40 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, the patch applied.On Fri, Jun 11, 2021 at 7:20 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the attached patch for #6231.I have fixed all review comments given in the team.On Fri, Jun 4, 2021 at 8:09 PM Dave Page <dave.page@enterprisedb.com> wrote:On Fri, Jun 4, 2021 at 3:14 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi Dave,On Fri, Jun 4, 2021 at 7:23 PM Dave Page <dave.page@enterprisedb.com> wrote:HiOn Fri, Jun 4, 2021 at 2:34 PM Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hello,I want to propose a suggestion here, If we can display configuration data in category/tab like below then it will make sense for the user (instead of dumping everthing in one single textbox randomly from config file)
SMTP- config1=value1
- config2=value2
- config3=value3 ...AUTHENTICATION- KERBERSOE- config1=value1
- config2=value2
- config3=value3 ...- LDAP- config1=value1
- config2=value2
- config3=value3 ...
SECURITY- config1=value1
- config2=value2
- config3=value3 ...It would, but it's not really worth the effort. This is really intended as debugging info the user can just copy/paste into an email to us.If it is for debugging purpose only then can we just place a "Copy configuration" button and hide this textbox, by clicking on the button will copy all the pgadmin4 configuration on the user's clipboard and can avoid clutter from the about window.It's still useful to read it occasionally IMHO.Regards,
MurtuzaOn Fri, Jun 4, 2021 at 5:33 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find the updated patch. I have fixed the OS details issue for Linux, MacOS big sur.On Tue, Jun 1, 2021 at 8:48 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Thanks, patch applied.On Tue, Jun 1, 2021 at 2:03 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Akshay,Please find an updated patch.On Mon, May 24, 2021 at 4:45 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi PradipFollowing are the review comments:
- Following labels should be changed
- Browser Details -> Browser
- OS -> Operating System
- Config DB -> pgAdmin Database File
Done.
- Server Configuration Text Area should be readonly and it should have a "col-sm-9" class instead of "col-sm-3".
Done.
- If the user resizes the About dialog then instead of showing blank space can we automatically resize the Server configuration text area?
Done.
- The height of the About dialog in the Server mode should be less as we are not showing "Server Configuration".
Done.
- In Runtime, we should merge the 'Browser details' in 'NW.js version' like 0.51.2 (Chromium 89.0.4389.114) OR at least prefix 'Chromium' before the version in the 'Browser details'.
Done.
- Found string difference in OS details for Runtime and Desktop mode.
- OSX: "Intel Mac OS X 10_15_7" in Runtime, while "Mac OS X 10.15.7" in Dekstop mode.
- Windows: "Win64" in Runtime, while "Windows 10" in Desktop which also not correct, I am using "Windows Server 2016".
- Following issue found on Firefox (First Image) configuration in a single line, Safari (Second image) too many scroll bars.
Done..
On Fri, May 21, 2021 at 2:23 PM Pradip Parkale <pradip.parkale@enterprisedb.com> wrote:Hi Hackers,Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up.Server configuration won't be visible to the non-admin users in server mode.--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Dave PageVP, Chief Architect, Database Infrastructure
Blog: https://www.enterprisedb.com/dave-page
Twitter: @pgsnake
EDB: https://www.enterprisedb.com--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation--Thanks & RegardsAkshay JoshipgAdmin Hacker | Principal Software ArchitectEDB PostgresMobile: +91 976-788-8246--Thanks & Regards,Pradip Parkale
Software Engineer | EnterpriseDB Corporation
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB PostgresMobile: +91 976-788-8246