Thread: Mention of PG 14 in docs
In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
see this text:
--> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
--> <productname>PostgreSQL</productname> 14, these indexes also support
equality operator (simple comparison operators are not supported).
Note that those indexes may not be as efficient as regular B-tree indexes
for equality operator.
As far as I know, we don't usually mention what version _added_ a
feature like this. I suggest the PG 14 mention be removed.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
On Mon, May 3, 2021 at 07:49:14PM -0400, Bruce Momjian wrote: > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I > see this text: > > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in > --> <productname>PostgreSQL</productname> 14, these indexes also support > equality operator (simple comparison operators are not supported). > Note that those indexes may not be as efficient as regular B-tree indexes > for equality operator. > > As far as I know, we don't usually mention what version _added_ a > feature like this. I suggest the PG 14 mention be removed. Also, what does "simple comparison operators are not supported" mean? -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
On Mon, May 3, 2021 at 08:10:24PM -0400, Bruce Momjian wrote:
> On Mon, May 3, 2021 at 07:49:14PM -0400, Bruce Momjian wrote:
> > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I
> > see this text:
> >
> > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in
> > --> <productname>PostgreSQL</productname> 14, these indexes also support
> > equality operator (simple comparison operators are not supported).
> > Note that those indexes may not be as efficient as regular B-tree indexes
> > for equality operator.
> >
> > As far as I know, we don't usually mention what version _added_ a
> > feature like this. I suggest the PG 14 mention be removed.
>
> Also, what does "simple comparison operators are not supported" mean?
Please ignore this second question since is has been fixed by:
Author: Alexander Korotkov <akorotkov@postgresql.org>
2020-11-16 [7adb8feb0] Reword 'simple comparison' => 'inequality' in pgtrgm.sgm
Reword 'simple comparison' => 'inequality' in pgtrgm.sgml
Discussion: https://postgr.es/m/CAMkU%3D1zxfA8_MGBW6sJMj54p8nPoe4bMb5LoG-rMYZVPq4j08Q%40mail.gmail.com
Author: Jeff Janes
The first question about PG 14 is still valid.
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com
If only the physical world exists, free will is an illusion.
Hi, Bruce! On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <bruce@momjian.us> wrote: > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I > see this text: > > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in > --> <productname>PostgreSQL</productname> 14, these indexes also support > equality operator (simple comparison operators are not supported). > Note that those indexes may not be as efficient as regular B-tree indexes > for equality operator. > > As far as I know, we don't usually mention what version _added_ a > feature like this. I suggest the PG 14 mention be removed. I agree with this. Thank you for pointing. Are you OK with the attached patch? ------ Regards, Alexander Korotkov
Attachment
On Tue, May 4, 2021 at 03:51:51AM +0300, Alexander Korotkov wrote: > Hi, Bruce! > > On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <bruce@momjian.us> wrote: > > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I > > see this text: > > > > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in > > --> <productname>PostgreSQL</productname> 14, these indexes also support > > equality operator (simple comparison operators are not supported). > > Note that those indexes may not be as efficient as regular B-tree indexes > > for equality operator. > > > > As far as I know, we don't usually mention what version _added_ a > > feature like this. I suggest the PG 14 mention be removed. > > I agree with this. Thank you for pointing. Are you OK with the attached patch? Yes, sure. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com If only the physical world exists, free will is an illusion.
On Tue, May 4, 2021 at 3:55 AM Bruce Momjian <bruce@momjian.us> wrote: > On Tue, May 4, 2021 at 03:51:51AM +0300, Alexander Korotkov wrote: > > Hi, Bruce! > > > > On Tue, May 4, 2021 at 2:49 AM Bruce Momjian <bruce@momjian.us> wrote: > > > In patch "Handle equality operator in contrib/pg_trgm" (935f66665), I > > > see this text: > > > > > > --> <literal>~</literal> and <literal>~*</literal> queries. Beginning in > > > --> <productname>PostgreSQL</productname> 14, these indexes also support > > > equality operator (simple comparison operators are not supported). > > > Note that those indexes may not be as efficient as regular B-tree indexes > > > for equality operator. > > > > > > As far as I know, we don't usually mention what version _added_ a > > > feature like this. I suggest the PG 14 mention be removed. > > > > I agree with this. Thank you for pointing. Are you OK with the attached patch? > > Yes, sure. Perfect, pushed. ------ Regards, Alexander Korotkov