Postgres Pro
Downloads
Home   >   mailing lists

Thread: Fix redundant comments in fmgr.c

Fix redundant comments in fmgr.c

From
"houzj.fnst@fujitsu.com"
Date:

Hi,

 

I found some possible redundant comments in fmgr.c

 

1.

fmgr_symbol(Oid functionId, char **mod, char **fn)

{

              HeapTuple          procedureTuple;

              Form_pg_proc procedureStruct;

              bool                     isnull;

              Datum                 prosrcattr;

            Datum                 probinattr;

-             /* Otherwise we need the pg_proc entry */

              procedureTuple = SearchSysCache1(PROCOID, ObjectIdGetDatum(functionId));

 

I guess the comment here was miscopied from fmgr_info_cxt_security:

 

 

 

2.

              if (!HeapTupleIsValid(procedureTuple))

                          elog(ERROR, "cache lookup failed for function %u", functionId);

            procedureStruct = (Form_pg_proc) GETSTRUCT(procedureTuple);

-             /*

-             */

 

Best regards,

houzj

 

 

Attachment

Re: Fix redundant comments in fmgr.c

From
Michael Paquier
Date:
On Thu, Apr 22, 2021 at 11:44:10AM +0000, houzj.fnst@fujitsu.com wrote:
> I found some possible redundant comments in fmgr.c

Thanks, fixed.  I have noticed one extra inconsistency at the top of
fmgr_symbol().

> I guess the comment here was miscopied from fmgr_info_cxt_security:

Right, coming right from the fast path in the other function.
--
Michael
Attachment